Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] trunk from cli:trunk #83

Open
wants to merge 1,434 commits into
base: trunk
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
1434 commits
Select commit Hold shift + click to select a range
457274b
Merge branch 'trunk' into 9292-add-remove-milestone-option
babakks Jul 29, 2024
842562d
Use closure-scoped variable to catch `--remove-milestone` option
babakks Jul 29, 2024
a73ae65
Use closure-scoped variable to catch `--remove-milestone` option
babakks Jul 29, 2024
58e6196
Fix missing variable
babakks Jul 29, 2024
b05bddc
Merge pull request #9344 from babakks/9292-add-remove-milestone-option
andyfeller Jul 29, 2024
b996380
Use signature-stripped tag annotation content
babakks Jul 29, 2024
df3b062
Add test for `gitTagInfo`
babakks Jul 29, 2024
46814b3
Add example for `--notes-from-tag`
babakks Jul 29, 2024
8ea1b89
Update tests with changes to `gitTagInfo` function
babakks Jul 29, 2024
dc4e9cb
handle attest case insensitivity
ejahnGithub Jul 30, 2024
c1adb1a
added
ejahnGithub Jul 30, 2024
e21e5ef
update test
ejahnGithub Jul 30, 2024
580ddf6
minor fix
ejahnGithub Jul 30, 2024
596ee8b
update test
ejahnGithub Jul 30, 2024
12715fd
Merge branch 'trunk' into eugene/gh-attestation-case-insensitivity
ejahnGithub Jul 30, 2024
a7d04fc
Add Flox as an installation option
Jul 30, 2024
1eaf712
update test and remove logic to check SourceRepositoryOwnerURI is emp…
ejahnGithub Jul 31, 2024
87ff22d
Merge branch 'tmp-07-31' into eugene/gh-attestation-case-insensitivity
ejahnGithub Jul 31, 2024
ad96ad3
build(deps): bump actions/attest-build-provenance from 1.3.3 to 1.4.0
dependabot[bot] Jul 31, 2024
89cbcfe
Merge pull request #9392 from cli/eugene/gh-attestation-case-insensit…
ejahnGithub Jul 31, 2024
22a5a4c
Update `gh variable get` to use repo host
andyfeller Aug 2, 2024
d7b8ecf
Unify use of tab indent in non-test source files
muzimuzhi Aug 1, 2024
c088951
Fix host handling in variable and secret delete
andyfeller Aug 2, 2024
20d3931
tmp
ejahnGithub Aug 5, 2024
8d17896
refactor the logic and logging
ejahnGithub Aug 5, 2024
8ae4f1c
add contain check
ejahnGithub Aug 5, 2024
bad127c
clean naming
ejahnGithub Aug 5, 2024
626bbf0
Merge pull request #9411 from cli/andyfeller/cli-9274-gh-variable-get…
andyfeller Aug 6, 2024
983e13c
Merge pull request #9400 from cli/dependabot/github_actions/actions/a…
andyfeller Aug 6, 2024
000b2f9
Merge branch 'trunk' into tab-indents
andyfeller Aug 6, 2024
86964d8
Merge pull request #9407 from muzimuzhi/tab-indents
andyfeller Aug 6, 2024
8356df0
build(deps): bump github.com/google/go-containerregistry
dependabot[bot] Aug 7, 2024
e2275d7
Add `pr create --editor`
benebsiny Aug 7, 2024
57aea66
added test
ejahnGithub Aug 7, 2024
d1cd69c
minor fixed
ejahnGithub Aug 7, 2024
832a430
minor fixed
ejahnGithub Aug 7, 2024
cc0fe09
Merge branch 'trunk' into eugene/attestation/fetch-oci-bundle
ejahnGithub Aug 7, 2024
c5ea30d
Add Acceptance Criteria requirement to triage.md for accepted issues
jtmcg Aug 7, 2024
fa06623
Update docs/triage.md
jtmcg Aug 7, 2024
40ccd2e
Merge pull request #9435 from cli/add-AC-to-triage-reqs
jtmcg Aug 7, 2024
e18c002
Deduplicate the initialization of editor mode
benebsiny Aug 8, 2024
330a385
Document that `gh run download` downloads the latest artifact by default
sato11 Aug 8, 2024
ab34d86
Change `gh repo set-default --view` to print to `stderr` when no defa…
thecaffeinedev Aug 8, 2024
dbcac5a
Merge pull request #9412 from sato11/docs-run-download-n
andyfeller Aug 8, 2024
7fe14ee
Merge pull request #9432 from cli/dependabot/go_modules/github.com/go…
andyfeller Aug 9, 2024
574e131
Require Sigstore Bundle v0.3 when verifying with `gh attestation`
codysoyland Aug 9, 2024
b783441
Fix tests
codysoyland Aug 9, 2024
35b2cf7
Change to requiring bundle v0.2
codysoyland Aug 9, 2024
18d58b8
Replace `--project.*` flags' `name` with `title` in docs (#9443)
jtmcg Aug 9, 2024
ac77d67
Wrap flags with backticks, continued
muzimuzhi Aug 10, 2024
3ca7090
Merge pull request #9444 from muzimuzhi/docs/unify-markup
andyfeller Aug 10, 2024
b36b39d
Explain why not looking for signature begin marker
babakks Aug 10, 2024
668dbce
Add test cases for PGP, SSH and X.509 signatures
babakks Aug 10, 2024
6dc7297
Merge branch 'trunk' into 9299-improve-annotated-releases
babakks Aug 10, 2024
58ff5c4
Merge pull request #9385 from babakks/9299-improve-annotated-releases
andyfeller Aug 12, 2024
369a105
Minor grammatical fix
andyfeller Aug 12, 2024
a863dfd
Merge pull request #9433 from benebsiny/cli-9310
andyfeller Aug 12, 2024
5ae03d6
addded more test
ejahnGithub Aug 12, 2024
7539f2a
Merge branch 'trunk' into eugene/attestation/fetch-oci-bundle
ejahnGithub Aug 12, 2024
da43f6e
build(deps): bump actions/attest-build-provenance from 1.4.0 to 1.4.1
dependabot[bot] Aug 12, 2024
f33c989
Merge pull request #9451 from cli/dependabot/github_actions/actions/a…
andyfeller Aug 12, 2024
e5248b8
Update `gh search prs --project` flag doc to specify `owner/number` s…
jtmcg Aug 12, 2024
c838da9
Update `gh search issues --project` flag doc to specify `owner/number…
jtmcg Aug 12, 2024
9e27af9
Merge pull request #9442 from cli/require-sigstore-bundle-v0.3
codysoyland Aug 13, 2024
025dcc8
Use latest checkout version, generate attestations, and specify go ve…
BagToad Aug 14, 2024
820f4f3
Do not generate build attestations for otherBinWorkflow.yml
BagToad Aug 14, 2024
0835642
build(deps): bump github.com/creack/pty from 1.1.21 to 1.1.23 (#9459)
dependabot[bot] Aug 14, 2024
5b7070f
include required permissions to generate attestations
BagToad Aug 14, 2024
0589196
udpate the options
ejahnGithub Aug 15, 2024
4618a26
Update attestation TUF root
codysoyland Aug 15, 2024
d707102
Add a note about external contributors to `working-with-us.md`
BagToad Aug 15, 2024
04e111d
Merge branch 'trunk' into eugene/attestation/fetch-oci-bundle
ejahnGithub Aug 15, 2024
0e690fa
Merge pull request #9462 from cli/9394-update-go-extension-workflow-t…
andyfeller Aug 15, 2024
0140e3d
Merge pull request #9468 from cli/BagToad-external-contributors-note
BagToad Aug 15, 2024
255f530
Merge pull request #9467 from cli/attestation-tuf-root-update
kommendorkapten Aug 16, 2024
009838a
Always print URL scheme to stdout
heaths Aug 15, 2024
81f3526
Fix tests
heaths Aug 15, 2024
6b9a0aa
Check http scheme as well
heaths Aug 16, 2024
1886fb4
Fix pr checks exit code (#9452)
thecaffeinedev Aug 16, 2024
800f99d
Describe bucket and state JSON fields in pr checks command
arunsathiya Aug 9, 2024
56e1cda
fix behavior for `issue develop -b non-exist-branch`
benebsiny Aug 17, 2024
216c283
Merge branch 'trunk' into cli-9496
benebsiny Aug 17, 2024
e269d43
add testing
benebsiny Aug 17, 2024
04b4122
Update api/queries_branch_issue_reference.go
benebsiny Aug 18, 2024
08aafc5
Update pkg/cmd/issue/develop/develop.go
benebsiny Aug 18, 2024
64415df
fix the trimming of log filenames for `gh run view`
benebsiny Aug 18, 2024
7187db4
Merge pull request #9439 from arunsathiya/update/9205-pr-checks-json-…
williammartin Aug 19, 2024
d40175f
Add flox to linux installation instructions
williammartin Aug 19, 2024
4283adb
Merge pull request #9396 from bryanhonof/trunk
williammartin Aug 19, 2024
3fd309b
rename flag to bundle-from-oci
ejahnGithub Aug 19, 2024
4f681aa
Merge pull request #9477 from benebsiny/cli-9496
andyfeller Aug 19, 2024
95a2f95
Merge pull request #9453 from cli/jtmcg/project-v2-syntax-in-search
andyfeller Aug 20, 2024
47a8f4b
update error message
ejahnGithub Aug 20, 2024
0d38a2f
fixed the test
ejahnGithub Aug 21, 2024
e21d053
Merge branch 'trunk' into eugene/attestation/fetch-oci-bundle
ejahnGithub Aug 21, 2024
779a120
Merge pull request #9471 from heaths/issue9470
andyfeller Aug 21, 2024
c81ccab
Quote repo names consistently in `gh repo sync` stdout (#9491)
muzimuzhi Aug 21, 2024
ef9069a
Merge pull request #9421 from cli/eugene/attestation/fetch-oci-bundle
ejahnGithub Aug 22, 2024
2374e82
Fix doc typo for `repo sync`
muzimuzhi Aug 22, 2024
91eb340
Remove `Internal` from `gh repo create` prompt when owner is not an o…
jtmcg Aug 22, 2024
687a43f
Drop surplus trailing space char in flag names in web
muzimuzhi Aug 21, 2024
2695983
Merge pull request #9495 from muzimuzhi/web/drop-trailing-space-in-flag
andyfeller Aug 22, 2024
19daa35
Merge pull request #9482 from benebsiny/cli-9153
andyfeller Aug 22, 2024
1eecfd4
Added `--active` flag to the `gh auth status` command
velumuruganr Aug 24, 2024
8305a49
"offline" verification using the bundle of attestations without any a…
aryanbhosale Aug 26, 2024
b8db372
build(deps): bump actions/attest-build-provenance from 1.4.1 to 1.4.2…
dependabot[bot] Aug 26, 2024
e6cbfaa
Merge branch 'trunk' into auth-status-active
velumuruganr Aug 27, 2024
3274516
Merge pull request #9509 from muzimuzhi/typo/repo-sync
andyfeller Aug 28, 2024
db9c763
Merge branch 'trunk' into auth-status-active
velumuruganr Aug 28, 2024
192f57e
Improve the help message for -F (#9525)
Goooler Aug 28, 2024
03c34e7
Expand active test cases
andyfeller Aug 30, 2024
5562c14
chore: fix some function names
crystalstall Sep 2, 2024
2bd3c22
Merge pull request #9555 from crystalstall/trunk
williammartin Sep 2, 2024
9a0a7d4
verify 2nd artifact without swapping order (#9532)
aryanbhosale Sep 4, 2024
34d7ef7
`gh attestation verify` handles empty JSONL files (#9541)
malancas Sep 4, 2024
1b67b35
update bundle file parsing err messages
malancas Sep 4, 2024
8446079
Upgrade to sigstore-go v0.6.1
codysoyland Sep 4, 2024
ea1a3da
Rename ProtobufBundle to Bundle
codysoyland Sep 4, 2024
7c405e8
dont print err content
malancas Sep 5, 2024
57b2029
check for os.PathError
malancas Sep 5, 2024
668706c
print verify err
malancas Sep 5, 2024
043bdbe
Remove note explaining 2 year old GPG ID change
andyfeller Sep 6, 2024
78fa57d
Revert "Remove note explaining 2 year old GPG ID change"
andyfeller Sep 6, 2024
5a7cdff
Update linux install to point to GPG troubleshoot
andyfeller Sep 6, 2024
dd85d62
Merge pull request #9573 from cli/andyfeller/9569-remove-old-gpg-id-n…
williammartin Sep 6, 2024
a21e78b
build(deps): bump actions/attest-build-provenance from 1.4.2 to 1.4.3
dependabot[bot] Sep 6, 2024
82b5099
Merge pull request #9566 from cli/sigstore-go-v0.6.1
andyfeller Sep 6, 2024
500b619
Move non-integration test to different test file
codysoyland Sep 6, 2024
b14e430
Check for nil values to prevent nil dereference panic
codysoyland Sep 6, 2024
3b7b7a4
Merge pull request #9578 from cli/bundle-panic
codysoyland Sep 6, 2024
a3f9d85
Merge pull request #9575 from cli/dependabot/github_actions/actions/a…
williammartin Sep 9, 2024
945e2b7
Merge branch 'trunk' into verification-err-output
malancas Sep 9, 2024
bbefc5b
handle os.PathError in GetLocalAttestations
malancas Sep 9, 2024
78c1d00
Merge pull request #9577 from cli/move-non-integration-test
williammartin Sep 10, 2024
70e935b
get latest sigstore-go commit
malancas Sep 10, 2024
83519e4
check for sigstore-go validation errs
malancas Sep 10, 2024
4421110
go mod tidy
malancas Sep 10, 2024
f748f9e
Merge remote-tracking branch 'upstream/trunk' into verification-err-o…
malancas Sep 10, 2024
3814e82
check err in GetLocalAttestations
malancas Sep 10, 2024
50d3355
check specific err
malancas Sep 10, 2024
e2c33e5
use sigstore-go v0.6.2
malancas Sep 10, 2024
1b59ec8
This commit introduces tenancy aware attestation policy building.
kommendorkapten Aug 29, 2024
aa931c5
Merge pull request #9542 from kommendorkapten/policy-tenancy
kommendorkapten Sep 11, 2024
a0a2567
Suggest installing Rosetta when extension installation fails due to m…
timrogers Sep 11, 2024
22c1da0
Merge pull request #9520 from velumuruganr/auth-status-active
andyfeller Sep 11, 2024
fbdf0cc
build(deps): bump github.com/sigstore/sigstore-go from 0.6.1 to 0.6.2
dependabot[bot] Sep 11, 2024
3cbaffe
Merge pull request #9601 from cli/dependabot/go_modules/github.com/si…
williammartin Sep 11, 2024
f128ae8
add att verify test for custom OIDC issuer
bdehamer Sep 10, 2024
c57a045
Merge pull request #9595 from cli/bdehamer/attest-verify-test-custom-…
bdehamer Sep 12, 2024
677edba
suppress att verify output when no tty
bdehamer Sep 12, 2024
5296d60
Refactor conditions
timrogers Sep 12, 2024
e0fb793
Stub hasRosetta for tests
williammartin Sep 12, 2024
99b789e
Add test for extension install fallback to amd64 on darwin
williammartin Sep 13, 2024
4430c40
Merge pull request #9599 from timrogers/timrogers/extension-arm64
williammartin Sep 13, 2024
352737c
Use api subdomains for commands using ghinstance package
williammartin Sep 13, 2024
e381d54
Merge pull request #9564 from malancas/verification-err-output
malancas Sep 13, 2024
0f42ee4
Merge pull request #9612 from cli/bdehamer/attest-verify-no-tty
malancas Sep 13, 2024
420d80b
Update go-gh to use api subdomains
williammartin Sep 13, 2024
d108784
Merge pull request #9618 from cli/wm/tenant-api
andyfeller Sep 16, 2024
24336f1
Enhance gh repo create docs, fix random cmd link
andyfeller Sep 16, 2024
8c8423a
better error for att verify custom issuer mismatch
bdehamer Sep 12, 2024
2e13ec5
Merge pull request #9616 from cli/bdehamer/custom-issuer-error
bdehamer Sep 16, 2024
8e8fc69
disable auth check for att trusted-root cmd
bdehamer Sep 12, 2024
cbe8525
enforce auth for tenancy
bdehamer Sep 13, 2024
1511c9f
build(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.4 to 2.0.5
dependabot[bot] Sep 17, 2024
3bcedfe
Update pkg/cmd/attestation/trustedroot/trustedroot_test.go
bdehamer Sep 17, 2024
dded039
Improve the suggested command for creating an issue when an extension…
timrogers Sep 12, 2024
81d57a0
Improve error presentation
timrogers Sep 12, 2024
e7403b8
Add HasActiveToken to AuthConfig.
BagToad Sep 18, 2024
88d48f2
Add HasActiveToken method to AuthConfig interface
BagToad Sep 18, 2024
d8e77d2
Use new HasActiveToken method in trustedroot.go
BagToad Sep 18, 2024
d24dfbe
Update comment formatting
BagToad Sep 18, 2024
195188c
Update pkg/cmd/extension/manager.go
timrogers Sep 18, 2024
665e415
Fix test
timrogers Sep 18, 2024
71b2aea
Merge pull request #9630 from cli/andyfeller/8946-repo-create-license…
andyfeller Sep 18, 2024
49892e8
Merge pull request #9635 from cli/bagtoad/cli-9610-add-HasActiveToken…
bdehamer Sep 18, 2024
8123de9
fix tenant-awareness for trusted-root command
bdehamer Sep 18, 2024
337b284
Merge branch 'trunk' into bdehamer/disable-attestation-trusted-root-a…
bdehamer Sep 19, 2024
65a7e8c
Merge pull request #9608 from timrogers/timrogers/extension-binary-co…
jtmcg Sep 19, 2024
d451a43
Merge pull request #9610 from cli/bdehamer/disable-attestation-truste…
bdehamer Sep 19, 2024
5dd5246
Replace "GitHub Enterprise Server" with "other" in `gh auth login` pr…
jtmcg Sep 19, 2024
4679097
Add documentation explaining how to use `hostname` for `gh auth login`
jtmcg Sep 19, 2024
1ef7140
build(deps): bump github.com/henvic/httpretty from 0.1.3 to 0.1.4
dependabot[bot] Sep 20, 2024
5f60b3c
Merge branch 'trunk' into bdehamer/att-trusted-root-tenant-aware
bdehamer Sep 20, 2024
bc587f6
Sentence case 'Other' option in hostname prompt
jtmcg Sep 20, 2024
13e916b
Change prompts for `gh auth login` to reflect change from GHE to Other
jtmcg Sep 20, 2024
2059c63
Update language on docstring for `gh auth login`
jtmcg Sep 20, 2024
e63dc22
Merge pull request #9645 from cli/dependabot/go_modules/github.com/he…
jtmcg Sep 20, 2024
ccb830c
Shorten language on Authenticate with a GitHub host.
jtmcg Sep 20, 2024
1eda1b4
Emit a log message when extension installation falls back to a darwin…
timrogers Sep 21, 2024
3bacaab
Merge pull request #9638 from cli/bdehamer/att-trusted-root-tenant-aware
bdehamer Sep 23, 2024
029dc8f
Change conditional in promptForHostname to better reflect prompter ch…
jtmcg Sep 23, 2024
f4af65d
Update docs language to remove possible confusion around 'where you l…
jtmcg Sep 23, 2024
9f3f91f
Merge pull request #9642 from cli/jtmcg/503
jtmcg Sep 23, 2024
be7631c
Merge branch 'trunk' into dependabot/go_modules/github.com/cpuguy83/g…
BagToad Sep 23, 2024
fd8c463
First pass at implementing `gh repo license list`
BagToad Sep 23, 2024
5be5999
Merge pull request #9634 from cli/dependabot/go_modules/github.com/cp…
BagToad Sep 23, 2024
c843ddd
Add GPG key instructions to appropriate sections
its-miroma Sep 25, 2024
4de63ac
Include `dnf5` commands
its-miroma Sep 25, 2024
5db26f5
Merge pull request #9660 from its-miroma/trunk
BagToad Sep 28, 2024
21f0d94
Divide shared repo package and add queries tests
BagToad Sep 29, 2024
1aa2a82
Remove json output option
BagToad Sep 29, 2024
2f608e3
Cleanup rendering and tests
BagToad Sep 29, 2024
ac779ba
fix output capitalization
BagToad Sep 29, 2024
2b4464a
Fix ListLicenseTemplates doc
BagToad Sep 29, 2024
25cdce2
Update license table headings and tests
BagToad Sep 29, 2024
038b57c
implement gitignore list
BagToad Sep 29, 2024
c76acb6
Implement gitignore view
BagToad Sep 29, 2024
0bc0f8c
Implement license view
BagToad Sep 30, 2024
0b29bea
Update docs to allow community submitted designs
BagToad Sep 30, 2024
aef01e2
Revise wording
BagToad Sep 30, 2024
7b8e8be
Remove trailing space from heading
BagToad Sep 30, 2024
89628a4
fix typo
BagToad Sep 30, 2024
efe9841
Fix typo and wordsmithing
BagToad Sep 30, 2024
023a449
Update SECURITY.md
BagToad Oct 1, 2024
29192da
build(deps): bump github.com/theupdateframework/go-tuf/v2
dependabot[bot] Oct 1, 2024
3f3acde
Merge pull request #9688 from cli/dependabot/go_modules/github.com/th…
BagToad Oct 1, 2024
289b9bc
Apply suggestions from code review
BagToad Oct 1, 2024
8ba31dd
Merge pull request #9683 from cli/kw/github-cli-568-unblock-community…
BagToad Oct 1, 2024
dae0740
Merge pull request #9687 from cli/kw/improve-security.md-encourage-po…
BagToad Oct 2, 2024
e6d39eb
Print the login URL even when opening a browser
ulfjack Mar 6, 2023
9bd75d2
Merge pull request #9650 from timrogers/timrogers/log-platform-fallback
jtmcg Oct 3, 2024
d645fd4
Merge pull request #7091 from ulfjack/patch-1
BagToad Oct 3, 2024
4aff4eb
Allow user to override markdown wrap width via $GH_MDWIDTH from envir…
smemsh Sep 16, 2024
3be44fb
Move API calls to queries_repo.go
BagToad Oct 6, 2024
0f1320a
Refactor tests and add new tests
BagToad Oct 6, 2024
04ed1ed
Merge branch 'trunk' into bagtoad/cli-8946-list-licenses-and-gitignor…
BagToad Oct 6, 2024
dfddb16
Merge pull request #9626 from smemsh/markdown-maxwidth-env
jtmcg Oct 7, 2024
8a1e6ac
Apply suggestions from code review
BagToad Oct 8, 2024
ca01bb8
Handle errors from parsing hostname in auth flow
BagToad Oct 8, 2024
f47af31
Bump cli/oauth to 1.1.1
williammartin Oct 9, 2024
76ea939
Merge pull request #9729 from cli/kw/cli-9248-handle-error-in-hostnam…
williammartin Oct 9, 2024
c2a7756
Reverse repo/shared package name change
BagToad Oct 10, 2024
4ecb125
Update function names
BagToad Oct 10, 2024
f064bda
Add `Long` for license list indicating limitations
BagToad Oct 10, 2024
d6c6c6b
Fix ExactArgs invocation
BagToad Oct 10, 2024
282b329
Add SPDX ID to license list output
BagToad Oct 10, 2024
f07f498
Update help and fix heredoc indentation
BagToad Oct 10, 2024
a42d3e2
Fix license view help doc, add LICENSE.md example
BagToad Oct 10, 2024
8abed17
implement `--web` flag for license view
BagToad Oct 10, 2024
9b94bee
Refactor http error handling
BagToad Oct 10, 2024
922a157
Update help for license view
BagToad Oct 10, 2024
d457776
Merge branch 'trunk' into bagtoad/cli-8946-list-licenses-and-gitignor…
BagToad Oct 10, 2024
95ca152
Add examples for creating `.gitignore` files
BagToad Oct 10, 2024
9b0fc5d
Merge branch 'bagtoad/cli-8946-list-licenses-and-gitignore-options' o…
BagToad Oct 10, 2024
c6c938f
Apply suggestions from code review
BagToad Oct 11, 2024
b6cdbc9
Fix license list and view tests
BagToad Oct 11, 2024
2913708
Return nil instead of empty objects when err
BagToad Oct 11, 2024
41f5209
Fix api tests after function signature changes
BagToad Oct 11, 2024
b91dab4
Merge pull request #9721 from cli/bagtoad/cli-8946-list-licenses-and-…
andyfeller Oct 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
"offline" verification using the bundle of attestations without any a…
…dditional handling of the file (cli#9523)
  • Loading branch information
aryanbhosale authored Aug 26, 2024
commit 8305a49c3f7d5331d662c72e9956219fcfe37eae
5 changes: 5 additions & 0 deletions pkg/cmd/attestation/verification/attestation.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package verification

import (
"bufio"
"bytes"
"encoding/json"
"errors"
"fmt"
Expand Down Expand Up @@ -88,6 +89,10 @@ func loadBundlesFromJSONLinesFile(path string) ([]*api.Attestation, error) {
var line []byte
line, err = reader.ReadBytes('\n')
for err == nil {
if len(bytes.TrimSpace(line)) == 0 {
line, err = reader.ReadBytes('\n')
continue
}
var bundle bundle.ProtobufBundle
bundle.Bundle = new(protobundle.Bundle)
err = bundle.UnmarshalJSON(line)
Expand Down