Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] trunk from cli:trunk #83

Open
wants to merge 1,317 commits into
base: trunk
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
1317 commits
Select commit Hold shift + click to select a range
cd5562f
Add `signer-repo` and `signer-workflow` flags to `gh attestation veri…
malancas May 30, 2024
fc8b86b
Specify rpm repository to avoid conflicts with community repositories
hbenali May 30, 2024
31a9d08
Merge pull request #9151 from hbenali/fix-fedora
andyfeller May 30, 2024
a10e532
feat: add `-a` flag to `gh run list`
joshuajtward Jun 3, 2024
3a1f385
Add GH_DEBUG to issue template
TWiStErRob Jun 4, 2024
215456e
build(deps): bump actions/attest-build-provenance from 1.1.2 to 1.2.0
dependabot[bot] Jun 4, 2024
e8a13cf
replaced deprecated --json-result flag with --format=json in the gh a…
phillmv Jun 4, 2024
58b459f
Merge pull request #9172 from cli/phillmv/fix-small-verify-flag-bug
phillmv Jun 4, 2024
d666248
build(deps): bump goreleaser/goreleaser-action from 5 to 6
dependabot[bot] Jun 5, 2024
e91860d
Bump go-keyring to fix keepassxc prompt confirmation
AlanD20 Jun 7, 2024
6f558c9
Merge pull request #9179 from AlanD20/bump-go-keyring
williammartin Jun 7, 2024
8ac5ad7
Merge branch 'trunk' into 8426-add-pr-update-cmd-no-local-update
babakks Jun 7, 2024
e36d8f1
Merge pull request #9169 from cli/dependabot/github_actions/actions/a…
williammartin Jun 10, 2024
1a470b3
build(deps): bump github.com/gorilla/websocket from 1.5.1 to 1.5.2
dependabot[bot] Jun 10, 2024
945b668
build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2
dependabot[bot] Jun 11, 2024
7cd4a15
Merge pull request #9175 from cli/dependabot/github_actions/gorelease…
andyfeller Jun 12, 2024
7d36c2d
Merge pull request #9192 from cli/dependabot/go_modules/github.com/go…
andyfeller Jun 12, 2024
04d0ec0
Merge pull request #9197 from cli/dependabot/go_modules/google.golang…
andyfeller Jun 12, 2024
c2f2753
add comment to call out potentially brittle use of workflowShared
joshuajtward Jun 13, 2024
f647131
Gracefully degrade when fetching annotations fails due to 403 (#9113)
wingleung Jun 13, 2024
6190e26
Add `gh run list` tests for workflow selector
andyfeller Jun 13, 2024
5e7ba54
Merge pull request #9162 from joshuajtward/chore/GH-9038
andyfeller Jun 13, 2024
307d07e
Update .github/ISSUE_TEMPLATE/bug_report.md
TWiStErRob Jun 13, 2024
59fae5b
build(deps): bump github.com/gorilla/websocket from 1.5.2 to 1.5.3
dependabot[bot] Jun 14, 2024
c572383
Attestation Verification - Buffer Fix (#9198)
Forrin Jun 14, 2024
f8e1271
Merge branch 'trunk' into 8426-add-pr-update-cmd-no-local-update
babakks Jun 16, 2024
6e77b2d
build(deps): bump github.com/spf13/cobra from 1.8.0 to 1.8.1
dependabot[bot] Jun 17, 2024
651d713
build(deps): bump actions/attest-build-provenance from 1.2.0 to 1.3.2
dependabot[bot] Jun 18, 2024
f71d3f7
Merge pull request #9222 from cli/dependabot/github_actions/actions/a…
andyfeller Jun 21, 2024
152607e
Removed beta note from `gh at verify`, clarified reusable workflows u…
phillmv Jun 24, 2024
40abc9a
Removed beta note from `gh at download`.
phillmv Jun 24, 2024
8318e7a
Actually, let's keep `download` in beta for now.
phillmv Jun 24, 2024
846b6ec
Fix whitespacing
williammartin Jun 24, 2024
d7c56bf
Remove beta note from attestation top level command
williammartin Jun 24, 2024
cdc8c4d
Merge pull request #9211 from cli/dependabot/go_modules/github.com/go…
williammartin Jun 24, 2024
31b424a
build(deps): bump github.com/google/go-containerregistry
dependabot[bot] Jun 24, 2024
f603231
Merge pull request #9218 from cli/dependabot/go_modules/github.com/sp…
williammartin Jun 24, 2024
06607d3
s/originated/caller/ workflow
phillmv Jun 24, 2024
ba2d32b
Merge pull request #9217 from cli/dependabot/go_modules/github.com/go…
williammartin Jun 24, 2024
c25dacc
Update pkg/cmd/attestation/verify/verify.go
phillmv Jun 24, 2024
c9f9fac
Update pkg/cmd/attestation/verify/verify.go
phillmv Jun 24, 2024
467550a
Merge pull request #9243 from cli/remove-attestation-public-beta
phillmv Jun 24, 2024
ee7bca6
build(deps): bump github.com/hashicorp/go-retryablehttp
dependabot[bot] Jun 24, 2024
812889f
Merge pull request #9128 from babakks/9118-add-json-fields-to-variabl…
williammartin Jun 25, 2024
85387fd
Update .github/ISSUE_TEMPLATE/bug_report.md
andyfeller Jun 25, 2024
70c3ca3
Merge pull request #9167 from TWiStErRob/patch-1
andyfeller Jun 25, 2024
d4e3385
Fetch variable selected repo relationship when required
williammartin Jun 25, 2024
c726703
Merge pull request #9256 from cli/9255-gh-variable-list-json-numselec…
andyfeller Jun 25, 2024
0f2e1ed
Merge pull request #9250 from cli/dependabot/go_modules/github.com/ha…
williammartin Jun 25, 2024
a994edd
Merge branch 'trunk' into 8426-add-pr-update-cmd-no-local-update
babakks Jun 27, 2024
f972050
gh attestation trusted-root subcommand (#9206)
steiza Jul 1, 2024
9b40e0c
Update create.go
cchristous Jul 7, 2024
0df5596
Merge pull request #9296 from cchristous/patch-1
williammartin Jul 8, 2024
8f77b4a
Add `issue create --editor`
notomo Mar 19, 2023
30b3286
Add prefer_editor_prompt config
notomo Jul 3, 2024
50d0cb7
Use prefer_editor_prompt config by `issue create`
notomo Jul 4, 2024
0d37174
Add editor hint message
notomo Jul 8, 2024
0b32e66
Enable to use --web even though editor is enabled by config
notomo Jul 9, 2024
4511a8b
build(deps): bump actions/attest-build-provenance from 1.3.2 to 1.3.3
dependabot[bot] Jul 10, 2024
172a9de
Ensure PR does not panic when stateReason is requested
williammartin Jul 11, 2024
3b2ba9e
docs: Update documentation for `gh repo create` to clarify owner
jessehouwing Jul 12, 2024
db733e1
Merge pull request #9305 from cli/dependabot/github_actions/actions/a…
williammartin Jul 12, 2024
ca1f2a4
Merge pull request #9309 from jessehouwing/docs/gh-repo-create-owner
williammartin Jul 12, 2024
940b54c
Add tests for JSON field support on issue and pr view commands
williammartin Jul 11, 2024
f44f9a4
Merge pull request #9307 from cli/wm/9160-stateReason-panic
williammartin Jul 12, 2024
28cc56c
Raise error if editor is used in non-tty mode
notomo Jul 13, 2024
ae5a71b
Merge branch 'trunk' into add-issue-create-editor
andyfeller Jul 15, 2024
9b7ee3a
Merge pull request #7193 from notomo/add-issue-create-editor
andyfeller Jul 15, 2024
c70479a
Merge branch 'trunk' into 8426-add-pr-update-cmd-no-local-update
babakks Jul 16, 2024
171e8d3
Print message on stdout instead of stderr
babakks Jul 16, 2024
1a6f598
Remove unused flag
babakks Jul 16, 2024
feb5aa5
Add separate type for `PullRequest.Mergeable` field
babakks Jul 16, 2024
28c72eb
Replace literals with consts for `Mergeable` field values
babakks Jul 16, 2024
497a915
Return error if PR is not mergeable
babakks Jul 16, 2024
5d2378d
Handle merge conflict error
babakks Jul 16, 2024
989152e
Add test case for merge conflict error
babakks Jul 16, 2024
b584895
Rename `gh pr update` to `gh pr update-branch`
babakks Jul 17, 2024
5b71586
Rename package name to `update_branch`
babakks Jul 17, 2024
5b918cf
Rename package directory and files
babakks Jul 17, 2024
d3d73d9
Merge pull request #8953 from babakks/8426-add-pr-update-cmd-no-local…
williammartin Jul 17, 2024
e0c03fc
Remove redundant whitespace
jessehouwing Jul 18, 2024
d02f58f
Merge pull request #9334 from jessehouwing/patch-1
williammartin Jul 18, 2024
a81a1f7
Remove attestation test that requires being online (#9340)
steiza Jul 19, 2024
17257df
Verify `--body` and `--body-file` are not assignable at the same time
babakks Jul 21, 2024
9dabc3b
Remove unused expected `output` from test case (with `wantsErr: true`)
babakks Jul 21, 2024
683576d
Add `--remove-milestone` option
babakks Jul 21, 2024
168a883
Assert correct parsing of `--remove-milestone` option
babakks Jul 21, 2024
42da8ba
Verify `--milestone` and `--remove-milestone` are not assignable at t…
babakks Jul 21, 2024
0a3a128
Exit with 1 on authentication failure
Stausssi Jun 23, 2024
a6a1a58
Update documentation for gh api PATCH
cmbuckley Jul 22, 2024
e760636
document exit code behavior
Stausssi Jul 22, 2024
a4da98d
Merge pull request #9352 from cmbuckley/docs-api-patch
williammartin Jul 22, 2024
32e499e
Add examples for template usage in PR and issue creation
williammartin Jul 23, 2024
8a0d361
Expose fullDatabaseId for PR json export
williammartin Jun 23, 2024
13dea3e
Add test for release view json export fields
williammartin Jul 23, 2024
99ff84b
Alphabetise release json fields
williammartin Jul 23, 2024
c13d161
Export databaseId for releases
williammartin Jul 23, 2024
5df84b5
Merge pull request #9354 from cli/9220-getting-template-not-found-err…
andyfeller Jul 23, 2024
78c3361
Merge pull request #9356 from cli/9278-gh-release-view-with-json-pars…
andyfeller Jul 23, 2024
c16becc
Slightly clarify when CLI will exit with 4
williammartin Jul 23, 2024
adc8b82
Merge pull request #9355 from cli/wm/9241-fulldatabaseid
williammartin Jul 24, 2024
fd51a69
Handle `--bare` clone targets (#9271)
hyperrealist Jul 24, 2024
8da9ee2
Merge pull request #9358 from cli/9338-gh-attestation-can-fail-with-h…
andyfeller Jul 24, 2024
658f125
Update sigstore-go in gh CLI to v0.5.1 (#9366)
steiza Jul 25, 2024
18894b6
Merge branch 'trunk' into fix-8845
andyfeller Jul 26, 2024
30f3a38
Merge pull request #9240 from Stausssi/fix-8845
andyfeller Jul 26, 2024
1fb6df6
build(deps): bump github.com/gabriel-vasile/mimetype from 1.4.4 to 1.4.5
dependabot[bot] Jul 26, 2024
9362143
Merge branch 'trunk' into 9292-add-remove-milestone-option
babakks Jul 28, 2024
6e34e81
Point to `Editable.MilestoneId` method
babakks Jul 28, 2024
4c8ec84
Improve `--remove-milestone` option description
babakks Jul 28, 2024
1520292
Add `--remove-milestone` option
babakks Jul 28, 2024
6dc8cc4
Verify `--body` and `--body-file` are not assignable at the same time
babakks Jul 28, 2024
605b4b1
Assert correct parsing of `--remove-milestone` option
babakks Jul 28, 2024
c9fb4ed
Verify `--milestone` and `--remove-milestone` are not assignable at t…
babakks Jul 28, 2024
d527775
Merge pull request #9372 from cli/dependabot/go_modules/github.com/ga…
andyfeller Jul 29, 2024
fbae0e2
build(deps): bump github.com/google/go-containerregistry
dependabot[bot] Jul 29, 2024
0d87dda
Merge pull request #9373 from cli/dependabot/go_modules/github.com/go…
andyfeller Jul 29, 2024
457274b
Merge branch 'trunk' into 9292-add-remove-milestone-option
babakks Jul 29, 2024
842562d
Use closure-scoped variable to catch `--remove-milestone` option
babakks Jul 29, 2024
a73ae65
Use closure-scoped variable to catch `--remove-milestone` option
babakks Jul 29, 2024
58e6196
Fix missing variable
babakks Jul 29, 2024
b05bddc
Merge pull request #9344 from babakks/9292-add-remove-milestone-option
andyfeller Jul 29, 2024
b996380
Use signature-stripped tag annotation content
babakks Jul 29, 2024
df3b062
Add test for `gitTagInfo`
babakks Jul 29, 2024
46814b3
Add example for `--notes-from-tag`
babakks Jul 29, 2024
8ea1b89
Update tests with changes to `gitTagInfo` function
babakks Jul 29, 2024
dc4e9cb
handle attest case insensitivity
ejahnGithub Jul 30, 2024
c1adb1a
added
ejahnGithub Jul 30, 2024
e21e5ef
update test
ejahnGithub Jul 30, 2024
580ddf6
minor fix
ejahnGithub Jul 30, 2024
596ee8b
update test
ejahnGithub Jul 30, 2024
12715fd
Merge branch 'trunk' into eugene/gh-attestation-case-insensitivity
ejahnGithub Jul 30, 2024
a7d04fc
Add Flox as an installation option
Jul 30, 2024
1eaf712
update test and remove logic to check SourceRepositoryOwnerURI is emp…
ejahnGithub Jul 31, 2024
87ff22d
Merge branch 'tmp-07-31' into eugene/gh-attestation-case-insensitivity
ejahnGithub Jul 31, 2024
ad96ad3
build(deps): bump actions/attest-build-provenance from 1.3.3 to 1.4.0
dependabot[bot] Jul 31, 2024
89cbcfe
Merge pull request #9392 from cli/eugene/gh-attestation-case-insensit…
ejahnGithub Jul 31, 2024
22a5a4c
Update `gh variable get` to use repo host
andyfeller Aug 2, 2024
d7b8ecf
Unify use of tab indent in non-test source files
muzimuzhi Aug 1, 2024
c088951
Fix host handling in variable and secret delete
andyfeller Aug 2, 2024
20d3931
tmp
ejahnGithub Aug 5, 2024
8d17896
refactor the logic and logging
ejahnGithub Aug 5, 2024
8ae4f1c
add contain check
ejahnGithub Aug 5, 2024
bad127c
clean naming
ejahnGithub Aug 5, 2024
626bbf0
Merge pull request #9411 from cli/andyfeller/cli-9274-gh-variable-get…
andyfeller Aug 6, 2024
983e13c
Merge pull request #9400 from cli/dependabot/github_actions/actions/a…
andyfeller Aug 6, 2024
000b2f9
Merge branch 'trunk' into tab-indents
andyfeller Aug 6, 2024
86964d8
Merge pull request #9407 from muzimuzhi/tab-indents
andyfeller Aug 6, 2024
8356df0
build(deps): bump github.com/google/go-containerregistry
dependabot[bot] Aug 7, 2024
e2275d7
Add `pr create --editor`
benebsiny Aug 7, 2024
57aea66
added test
ejahnGithub Aug 7, 2024
d1cd69c
minor fixed
ejahnGithub Aug 7, 2024
832a430
minor fixed
ejahnGithub Aug 7, 2024
cc0fe09
Merge branch 'trunk' into eugene/attestation/fetch-oci-bundle
ejahnGithub Aug 7, 2024
c5ea30d
Add Acceptance Criteria requirement to triage.md for accepted issues
jtmcg Aug 7, 2024
fa06623
Update docs/triage.md
jtmcg Aug 7, 2024
40ccd2e
Merge pull request #9435 from cli/add-AC-to-triage-reqs
jtmcg Aug 7, 2024
e18c002
Deduplicate the initialization of editor mode
benebsiny Aug 8, 2024
330a385
Document that `gh run download` downloads the latest artifact by default
sato11 Aug 8, 2024
ab34d86
Change `gh repo set-default --view` to print to `stderr` when no defa…
thecaffeinedev Aug 8, 2024
dbcac5a
Merge pull request #9412 from sato11/docs-run-download-n
andyfeller Aug 8, 2024
7fe14ee
Merge pull request #9432 from cli/dependabot/go_modules/github.com/go…
andyfeller Aug 9, 2024
574e131
Require Sigstore Bundle v0.3 when verifying with `gh attestation`
codysoyland Aug 9, 2024
b783441
Fix tests
codysoyland Aug 9, 2024
35b2cf7
Change to requiring bundle v0.2
codysoyland Aug 9, 2024
18d58b8
Replace `--project.*` flags' `name` with `title` in docs (#9443)
jtmcg Aug 9, 2024
ac77d67
Wrap flags with backticks, continued
muzimuzhi Aug 10, 2024
3ca7090
Merge pull request #9444 from muzimuzhi/docs/unify-markup
andyfeller Aug 10, 2024
b36b39d
Explain why not looking for signature begin marker
babakks Aug 10, 2024
668dbce
Add test cases for PGP, SSH and X.509 signatures
babakks Aug 10, 2024
6dc7297
Merge branch 'trunk' into 9299-improve-annotated-releases
babakks Aug 10, 2024
58ff5c4
Merge pull request #9385 from babakks/9299-improve-annotated-releases
andyfeller Aug 12, 2024
369a105
Minor grammatical fix
andyfeller Aug 12, 2024
a863dfd
Merge pull request #9433 from benebsiny/cli-9310
andyfeller Aug 12, 2024
5ae03d6
addded more test
ejahnGithub Aug 12, 2024
7539f2a
Merge branch 'trunk' into eugene/attestation/fetch-oci-bundle
ejahnGithub Aug 12, 2024
da43f6e
build(deps): bump actions/attest-build-provenance from 1.4.0 to 1.4.1
dependabot[bot] Aug 12, 2024
f33c989
Merge pull request #9451 from cli/dependabot/github_actions/actions/a…
andyfeller Aug 12, 2024
e5248b8
Update `gh search prs --project` flag doc to specify `owner/number` s…
jtmcg Aug 12, 2024
c838da9
Update `gh search issues --project` flag doc to specify `owner/number…
jtmcg Aug 12, 2024
9e27af9
Merge pull request #9442 from cli/require-sigstore-bundle-v0.3
codysoyland Aug 13, 2024
025dcc8
Use latest checkout version, generate attestations, and specify go ve…
BagToad Aug 14, 2024
820f4f3
Do not generate build attestations for otherBinWorkflow.yml
BagToad Aug 14, 2024
0835642
build(deps): bump github.com/creack/pty from 1.1.21 to 1.1.23 (#9459)
dependabot[bot] Aug 14, 2024
5b7070f
include required permissions to generate attestations
BagToad Aug 14, 2024
0589196
udpate the options
ejahnGithub Aug 15, 2024
4618a26
Update attestation TUF root
codysoyland Aug 15, 2024
d707102
Add a note about external contributors to `working-with-us.md`
BagToad Aug 15, 2024
04e111d
Merge branch 'trunk' into eugene/attestation/fetch-oci-bundle
ejahnGithub Aug 15, 2024
0e690fa
Merge pull request #9462 from cli/9394-update-go-extension-workflow-t…
andyfeller Aug 15, 2024
0140e3d
Merge pull request #9468 from cli/BagToad-external-contributors-note
BagToad Aug 15, 2024
255f530
Merge pull request #9467 from cli/attestation-tuf-root-update
kommendorkapten Aug 16, 2024
009838a
Always print URL scheme to stdout
heaths Aug 15, 2024
81f3526
Fix tests
heaths Aug 15, 2024
6b9a0aa
Check http scheme as well
heaths Aug 16, 2024
1886fb4
Fix pr checks exit code (#9452)
thecaffeinedev Aug 16, 2024
800f99d
Describe bucket and state JSON fields in pr checks command
arunsathiya Aug 9, 2024
56e1cda
fix behavior for `issue develop -b non-exist-branch`
benebsiny Aug 17, 2024
216c283
Merge branch 'trunk' into cli-9496
benebsiny Aug 17, 2024
e269d43
add testing
benebsiny Aug 17, 2024
04b4122
Update api/queries_branch_issue_reference.go
benebsiny Aug 18, 2024
08aafc5
Update pkg/cmd/issue/develop/develop.go
benebsiny Aug 18, 2024
64415df
fix the trimming of log filenames for `gh run view`
benebsiny Aug 18, 2024
7187db4
Merge pull request #9439 from arunsathiya/update/9205-pr-checks-json-…
williammartin Aug 19, 2024
d40175f
Add flox to linux installation instructions
williammartin Aug 19, 2024
4283adb
Merge pull request #9396 from bryanhonof/trunk
williammartin Aug 19, 2024
3fd309b
rename flag to bundle-from-oci
ejahnGithub Aug 19, 2024
4f681aa
Merge pull request #9477 from benebsiny/cli-9496
andyfeller Aug 19, 2024
95a2f95
Merge pull request #9453 from cli/jtmcg/project-v2-syntax-in-search
andyfeller Aug 20, 2024
47a8f4b
update error message
ejahnGithub Aug 20, 2024
0d38a2f
fixed the test
ejahnGithub Aug 21, 2024
e21d053
Merge branch 'trunk' into eugene/attestation/fetch-oci-bundle
ejahnGithub Aug 21, 2024
779a120
Merge pull request #9471 from heaths/issue9470
andyfeller Aug 21, 2024
c81ccab
Quote repo names consistently in `gh repo sync` stdout (#9491)
muzimuzhi Aug 21, 2024
ef9069a
Merge pull request #9421 from cli/eugene/attestation/fetch-oci-bundle
ejahnGithub Aug 22, 2024
2374e82
Fix doc typo for `repo sync`
muzimuzhi Aug 22, 2024
91eb340
Remove `Internal` from `gh repo create` prompt when owner is not an o…
jtmcg Aug 22, 2024
687a43f
Drop surplus trailing space char in flag names in web
muzimuzhi Aug 21, 2024
2695983
Merge pull request #9495 from muzimuzhi/web/drop-trailing-space-in-flag
andyfeller Aug 22, 2024
19daa35
Merge pull request #9482 from benebsiny/cli-9153
andyfeller Aug 22, 2024
1eecfd4
Added `--active` flag to the `gh auth status` command
velumuruganr Aug 24, 2024
8305a49
"offline" verification using the bundle of attestations without any a…
aryanbhosale Aug 26, 2024
b8db372
build(deps): bump actions/attest-build-provenance from 1.4.1 to 1.4.2…
dependabot[bot] Aug 26, 2024
e6cbfaa
Merge branch 'trunk' into auth-status-active
velumuruganr Aug 27, 2024
3274516
Merge pull request #9509 from muzimuzhi/typo/repo-sync
andyfeller Aug 28, 2024
db9c763
Merge branch 'trunk' into auth-status-active
velumuruganr Aug 28, 2024
192f57e
Improve the help message for -F (#9525)
Goooler Aug 28, 2024
03c34e7
Expand active test cases
andyfeller Aug 30, 2024
5562c14
chore: fix some function names
crystalstall Sep 2, 2024
2bd3c22
Merge pull request #9555 from crystalstall/trunk
williammartin Sep 2, 2024
9a0a7d4
verify 2nd artifact without swapping order (#9532)
aryanbhosale Sep 4, 2024
34d7ef7
`gh attestation verify` handles empty JSONL files (#9541)
malancas Sep 4, 2024
8446079
Upgrade to sigstore-go v0.6.1
codysoyland Sep 4, 2024
ea1a3da
Rename ProtobufBundle to Bundle
codysoyland Sep 4, 2024
043bdbe
Remove note explaining 2 year old GPG ID change
andyfeller Sep 6, 2024
78fa57d
Revert "Remove note explaining 2 year old GPG ID change"
andyfeller Sep 6, 2024
5a7cdff
Update linux install to point to GPG troubleshoot
andyfeller Sep 6, 2024
dd85d62
Merge pull request #9573 from cli/andyfeller/9569-remove-old-gpg-id-n…
williammartin Sep 6, 2024
a21e78b
build(deps): bump actions/attest-build-provenance from 1.4.2 to 1.4.3
dependabot[bot] Sep 6, 2024
82b5099
Merge pull request #9566 from cli/sigstore-go-v0.6.1
andyfeller Sep 6, 2024
500b619
Move non-integration test to different test file
codysoyland Sep 6, 2024
b14e430
Check for nil values to prevent nil dereference panic
codysoyland Sep 6, 2024
3b7b7a4
Merge pull request #9578 from cli/bundle-panic
codysoyland Sep 6, 2024
a3f9d85
Merge pull request #9575 from cli/dependabot/github_actions/actions/a…
williammartin Sep 9, 2024
78c1d00
Merge pull request #9577 from cli/move-non-integration-test
williammartin Sep 10, 2024
1b59ec8
This commit introduces tenancy aware attestation policy building.
kommendorkapten Aug 29, 2024
aa931c5
Merge pull request #9542 from kommendorkapten/policy-tenancy
kommendorkapten Sep 11, 2024
22c1da0
Merge pull request #9520 from velumuruganr/auth-status-active
andyfeller Sep 11, 2024
fbdf0cc
build(deps): bump github.com/sigstore/sigstore-go from 0.6.1 to 0.6.2
dependabot[bot] Sep 11, 2024
3cbaffe
Merge pull request #9601 from cli/dependabot/go_modules/github.com/si…
williammartin Sep 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed the test
  • Loading branch information
ejahnGithub committed Aug 21, 2024
commit 0d38a2fd8e3a828deb8f92b7d5042463fff43709
4 changes: 2 additions & 2 deletions pkg/cmd/attestation/verify/verify_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ func TestRunVerify(t *testing.T) {
customOpts.UseBundleFromRegistry = true
customOpts.OCIClient = oci.NoAttestationsClient{}

require.ErrorContains(t, runVerify(&customOpts), "no OCI attestations found")
require.ErrorContains(t, runVerify(&customOpts), "no attestations found in the OCI registry. Retry the command without the --bundle-from-oci flag to check GitHub for the attestation")
})

t.Run("with valid OCI artifact with UseBundleFromRegistry flag but fail on fetching bundle from registry", func(t *testing.T) {
Expand All @@ -498,6 +498,6 @@ func TestRunVerify(t *testing.T) {
customOpts.UseBundleFromRegistry = true
customOpts.OCIClient = oci.NoAttestationsClient{}

require.ErrorContains(t, runVerify(&customOpts), "no OCI attestations found")
require.ErrorContains(t, runVerify(&customOpts), "no attestations found in the OCI registry. Retry the command without the --bundle-from-oci flag to check GitHub for the attestation")
})
}