Allow coercion on complex types for unpartitioned ORC tables #22326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
changed the title
marcinsbd
reviewed
Jun 11, 2024
plugin/trino-hive/src/main/java/io/trino/plugin/hive/coercions/VarbinaryToVarcharCoercers.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/orc/OrcTypeTranslator.java
Outdated
Show resolved
Hide resolved
| else { | ||
| Optional<TypeCoercer<? extends Type, ? extends Type>> coercer = createCoercer(nestedColumns.get(i).getColumnType(), nestedColumns.get(i).getNestedColumns(), rowType.getFields().get(i).getType()); | ||
|
|
||
| RowType.Field field = rowType.getFields().get(i); |
There was a problem hiding this comment.
how about
Type rowFieldType = rowType.getFields().get(i).getType();
instead?
Praveen2112
force-pushed
the
praveen/orc_structural_types_coercion
branch
from
2069874
to
ae2b44e
Compare
|
@krvikash / @marcinsbd AC |
plugin/trino-hive/src/main/java/io/trino/plugin/hive/orc/OrcTypeTranslator.java
Outdated
Show resolved
Hide resolved
Praveen2112
force-pushed
the
praveen/orc_structural_types_coercion
branch
from
ae2b44e
to
c857544
Compare
raunaqmorarka
approved these changes
Jun 20, 2024
|
The CI failure looks valid so I'll try to fix it out |
Praveen2112
force-pushed
the
praveen/orc_structural_types_coercion
branch
from
c857544
to
8c72ce3
Compare
Praveen2112
force-pushed
the
praveen/orc_structural_types_coercion
branch
from
8c72ce3
to
70362ac
Compare
|
@raunaqmorarka Added an additional check i.e if the field names are not in order then we would skip applying the coercion - This is in sync with |
raunaqmorarka
approved these changes
Jul 1, 2024
krvikash
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow coercion on complex/structural data types i.e list/map/struct for un-partitioned ORC tables.
Additional context and related issues
Depends on #22325
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: