Allow varbinary to varchar coercion for hive tables #22322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetTypeTranslator.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/orc/OrcTypeTranslator.java
Outdated
Show resolved
Hide resolved
Praveen2112
force-pushed
the
praveen/varbinary_to_varchar_2
branch
2 times, most recently
from
418e534
to
514df20
Compare
|
For varbinary to varchar - Each file format works in a different way. Will push additional changes. |
Praveen2112
force-pushed
the
praveen/varbinary_to_varchar_2
branch
from
514df20
to
db759d6
Compare
|
Have pushed my final set of changes. Wrt to hive coercion each format has its own way of handling binary to varchar coercion. |
Praveen2112
force-pushed
the
praveen/varbinary_to_varchar_2
branch
from
db759d6
to
6f4e35f
Compare
krvikash
approved these changes
Jun 11, 2024
plugin/trino-hive/src/main/java/io/trino/plugin/hive/coercions/CoercionUtils.java
Outdated
Show resolved
Hide resolved
marcinsbd
reviewed
Jun 11, 2024
plugin/trino-hive/src/main/java/io/trino/plugin/hive/coercions/VarbinaryToVarcharCoercers.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/coercions/VarbinaryToVarcharCoercers.java
Outdated
Show resolved
Hide resolved
Praveen2112
force-pushed
the
praveen/varbinary_to_varchar_2
branch
from
6f4e35f
to
729d1e1
Compare
|
@krvikash / @marcinsbd Thanks a lot for the review. AC |
marcinsbd
approved these changes
Jun 11, 2024
krvikash
approved these changes
Jun 11, 2024
Praveen2112
force-pushed
the
praveen/varbinary_to_varchar_2
branch
from
729d1e1
to
28f86cc
Compare
|
@raunaqmorarka Have applied the changes based on this comments - #22322 (comment) |
Praveen2112
force-pushed
the
praveen/varbinary_to_varchar_2
branch
from
28f86cc
to
c75ab95
Compare
raunaqmorarka
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: