Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convertQwertyToHangul split 및 Non-null assertion operator 제거, 네이밍 오타 수정 #75

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

ssi02014
Copy link
Contributor

@ssi02014 ssi02014 commented Apr 24, 2024

Overview

기존 코드를 보다가 일부 코드 및 오타를 수정하였습니다.

  1. convertQwertyToHangulAlphabet 함수가 반환하는 문자열은 iterable이기 때문에 전개 연산자(...)에 활용 될 수 있습니다. 현재 코드만 봤을 때 split('')을 통해 한번 더 배열로 변환 하는 것은 불 필요하지 않을까 생각합니다🙏 cc. @99mini
const str = "프론트엔드";
const arr = ["프", "론", "트", "엔", "드"];

console.log([...str]); // [ '프', '론', '트', '엔', '드' ]
console.log([...arr]); // [ '프', '론', '트', '엔', '드' ]

console.log([...str.split('')]); // [ '프', '론', '트', '엔', '드' ]
  1. 더 이상 타입 에러를 발생시키지 않기 때문에 Non-null assertion operator(!)를 제거했습니다!
  2. disassembedGroups -> disassembledGroups 오타 수정

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: 2c5f012

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 24, 2024

@ssi02014 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@ssi02014 ssi02014 changed the title refac: convertQwertyToHangul split 및 Non-null assertion operator 제거, 네이밍 오타 수정 fix: convertQwertyToHangul split 및 Non-null assertion operator 제거, 네이밍 오타 수정 Apr 24, 2024
Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM😄

@okinawaa okinawaa merged commit f2b7cd9 into toss:main Apr 25, 2024
1 of 2 checks passed
@ssi02014 ssi02014 deleted the refac/es-hangul branch April 25, 2024 10:14
@github-actions github-actions bot mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants