�fix: convertQwertyToHangul split 및 Non-null assertion operator 제거, 네…

…이밍 오타 수정 (#75) * refac: convertQwertyToHangul split 및 Non-null assertion operator 제거, 네이밍 오타 수정 * Create young-bears-double.md --------- Co-authored-by: 박찬혁 <[email protected]>
toss · Apr 25, 2024 · f2b7cd9 · f2b7cd9
1 parent 0c784ff
commit f2b7cd9
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/.changeset/young-bears-double.md b/.changeset/young-bears-double.md
@@ -0,0 +1,5 @@
+---
+"es-hangle": patch
+---
+
+refac: convertQwertyToHangul split 및 Non-null assertion operator 제거, 네이밍 오타 수정
diff --git a/src/convertQwertyToHangulAlphabet.ts b/src/convertQwertyToHangulAlphabet.ts
@@ -27,5 +27,5 @@ export function convertQwertyToHangul(word: string): string {
  if (!word) {
  return '';
  }
- return assembleHangul([...convertQwertyToHangulAlphabet(word).split('')]);
+ return assembleHangul([...convertQwertyToHangulAlphabet(word)]);
 }
diff --git a/src/disassembleCompleteHangulCharacter.ts b/src/disassembleCompleteHangulCharacter.ts
@@ -32,8 +32,8 @@ export function disassembleCompleteHangulCharacter(
  const firstIndex = Math.floor((hangulCode - lastIndex) / NUMBER_OF_JONGSUNG / NUMBER_OF_JUNGSUNG);
 
  return {
- first: HANGUL_CHARACTERS_BY_FIRST_INDEX[firstIndex]!,
- middle: HANGUL_CHARACTERS_BY_MIDDLE_INDEX[middleIndex]!,
- last: HANGUL_CHARACTERS_BY_LAST_INDEX[lastIndex]!,
+ first: HANGUL_CHARACTERS_BY_FIRST_INDEX[firstIndex],
+ middle: HANGUL_CHARACTERS_BY_MIDDLE_INDEX[middleIndex],
+ last: HANGUL_CHARACTERS_BY_LAST_INDEX[lastIndex],
  } as const;
 }
diff --git a/src/removeLastHangulCharacter.ts b/src/removeLastHangulCharacter.ts
@@ -18,14 +18,14 @@ import { excludeLastElement } from './_internal';
  * removeLastHangulCharacter('일요일') // 일요이
  */
 export function removeLastHangulCharacter(words: string) {
- const disassembedGroups = disassembleHangulToGroups(words);
- const lastCharacter = disassembedGroups.at(-1);
+ const disassembledGroups = disassembleHangulToGroups(words);
+ const lastCharacter = disassembledGroups.at(-1);
 
  if (lastCharacter == null) {
  return '';
  }
 
- const withoutLastCharacter = disassembedGroups
+ const withoutLastCharacter = disassembledGroups
  .filter(v => v !== lastCharacter)
  .map(([first, middle, last]) => {
  if (middle != null) {