Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed theme + migrated to newer Hugo features #70

Merged
merged 5 commits into from
Dec 9, 2019
Merged

Fixed theme + migrated to newer Hugo features #70

merged 5 commits into from
Dec 9, 2019

Conversation

kdevo
Copy link
Contributor

@kdevo kdevo commented Aug 24, 2019

Hi there,

first: Thanks for the cool theme!

I just applied the needed changes for #69 and got this theme working again.

Additionally, I did the following improvements ✨:

  • Implement native cache busting via the newer Hugo Pipes:
    • Use fingerprinting for the resource filenames
    • No additional setup needed anymore
    • Move to the newer assets directory:
      • Use the SCSS (sass) sources and convert them to CSS using resources.ToCSS
      • Use resources.Minify
      • Remove minified files where possible and only keep the sources
  • Remove Hugo linter warnings:
    • Use .Site.RegularPages instead of .Data.Pages where needed
    • Use .File.UniqueID instead of .UniqueID
    • Use {{ with .OutputFormats.Get "RSS" }} ...
    • Remove deprecated Hugo generator meta tag (will be injected automatically, anyways)
  • Pin version to Hugo 0.5 (maybe 0.43 would do the job, too)

⚠️ Please test this PR thoroughly before merging into master.

I just rapidly wanted to share my changes and help out a bit, but didn't have the time to test everything.

@tomanistor
Copy link
Owner

I appreciate the PR @kdevo! Let me test it out and I'll merge it in if it works.

This bug came up while developing git.io/osprey-delight.
So I decided to fix it here, too.
@kdevo
Copy link
Contributor Author

kdevo commented Dec 1, 2019

Just a note: As already commented in the yet closed #69 I forked this theme but still wanted to fix the above bug in the original merge request regarding the contact form functionality.
This was the only bug I encountered.

@tomanistor
Copy link
Owner

Thanks for the updates @kdevo! I've just tested on my own site and merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants