-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme demo broken on Hugo Themes Showcase #69
Comments
Small update: I could test my changes in PR #70. Seems all good so far. |
Thanks for the alert @onedrawingperday and the fixes @kdevo! I'll have some free time this week to test and merge. |
I should have opened an issue back when I first noticed this issue myself! Thought it was a misconfiguration on my end. I ended up locking my Osprey theme version to a9232a5 when I was first developing with it because of how this broke. If @kdevo 's PR gets merged, I'll definitely be taking a look at upgrading. Love the theme! |
Hi again, after using the theme for quite some time, I implemented some breaking changes to adjust to my requirements.
@tomanistor Hope you're OK with that! |
Unmaintained: tomanistor/osprey#69
I have now removed Osprey from the Hugo Themes showcase as per the guidelines:
If the above issue is fixed feel free to resubmit the theme at: https://github.com/gohugoio/hugoThemes/issues |
PR #70 has been merged to fix the example site. Thanks guys! |
Hello @tomanistor
Currently your theme's demo does not generate as mentioned in gohugoio/hugoThemes#669 (comment)
To fix you need to change line 8 of
theme.toml
to:min_version = "0.24.1"
The
min_version
needs to be a stringFurthermore after testing the above change I noticed the your theme's stylesheet is 404.
In line 83 of
layouts/partials/head.html
you reference amain.css
file that does not exist in the repo.Instead under
static/styles/
there is amain.min.css
Feel free to close this issue once you do the above
Also note that once gohugoio/hugoThemes#668 is addressed you will need to keep an eye on whether the Osprey theme demo generates on the Hugo website.
We are a very small team and we just cannot keep up opening issues in the various theme repositories. Whenever a theme demo breaks and remains broken then at some point it will be removed from the list without prior warning.
Thank you.
cc: @digitalcraftsman
The text was updated successfully, but these errors were encountered: