Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added facebook link at footer; Added _blank target on footer links to… #38

Merged
merged 2 commits into from
Mar 12, 2018
Merged

Added facebook link at footer; Added _blank target on footer links to… #38

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
944c5f2
Added facebook link at footer; Added _blank target on footer links to…
gustavotero7 Mar 8, 2018
c11cc0e
Fixed facebook link label and facebook field added to the readme exam…
gustavotero7 Mar 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions layouts/partials/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
<footer class="row middle-xs center-xs">

{{ if .Site.Params.facebook }}
<div class="col-xs-3 col-md-2"><a target="_blank" href="https://facebook.com/{{ .Site.Params.facebook }}">GitHub</a></div>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gustavotero7 thank you for the pull request! Would you mind fixing the link to say Facebook instead of GitHub, and adding the new param to README.md and exampleSite/config.toml before I merge it in?

{{ end }}

{{ if .Site.Params.github }}
<div class="col-xs-3 col-md-2"><a href="/{{ .Site.Params.github }}">GitHub</a></div>
<div class="col-xs-3 col-md-2"><a target="_blank" href="/{{ .Site.Params.github }}">GitHub</a></div>
{{ end }}

{{ if .Site.Params.linkedin }}
<div class="col-xs-3 col-md-2"><a href="https://linkedin.com/in/{{ .Site.Params.linkedin }}">LinkedIn</a></div>
<div class="col-xs-3 col-md-2"><a target="_blank" href="https://linkedin.com/in/{{ .Site.Params.linkedin }}">LinkedIn</a></div>
{{ end }}

{{ if .Site.Params.twitter }}
<div class="col-xs-3 col-md-2"><a href="https://twitter.com/{{ .Site.Params.twitter }}">Twitter</a></div>
<div class="col-xs-3 col-md-2"><a target="_blank" href="https://twitter.com/{{ .Site.Params.twitter }}">Twitter</a></div>
{{ end }}

{{ if or (.Site.Params.copyright) (.Site.Params.credit) }}
Expand Down