Added facebook link at footer; Added _blank target on footer links to… #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… open them in a new tab
tomanistor
requested changes
Mar 10, 2018
layouts/partials/footer.html
Outdated
| @@ -1,15 +1,19 @@ | |||
| <footer class="row middle-xs center-xs"> | |||
|
|
|||
| {{ if .Site.Params.facebook }} | |||
| <div class="col-xs-3 col-md-2"><a target="_blank" href="https://facebook.com/{{ .Site.Params.facebook }}">GitHub</a></div> | |||
There was a problem hiding this comment.
Hey @gustavotero7 thank you for the pull request! Would you mind fixing the link to say Facebook instead of GitHub, and adding the new param to README.md and exampleSite/config.toml before I merge it in?
…ple for config file
|
Hi @tomanistor sorry for the label error 😅 |
|
Done, check last commit |
|
No worries, thanks again! |
tomanistor
approved these changes
Mar 12, 2018
joeraut
pushed a commit
to joeraut/osprey
that referenced
this pull request
Jan 16, 2021
Added facebook link at footer; Added _blank target on footer links to…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added facebook link at footer.
Added _blank target on footer links to open them in a new tab.