Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mixpanel issues #6840

Merged
merged 1 commit into from
May 9, 2024
Merged

fix: mixpanel issues #6840

merged 1 commit into from
May 9, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 8, 2024

No description provided.

Copy link

graphite-app bot commented May 8, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented May 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 marked this pull request as ready for review May 8, 2024 11:21
@pengx17 pengx17 force-pushed the 05-08-feat_handle_login_required_tracking_event branch from 2de34b7 to cc302b2 Compare May 8, 2024 11:21
Copy link

nx-cloud bot commented May 8, 2024

@pengx17 pengx17 force-pushed the 05-08-fix_mixpanel_issues branch from 81ba042 to 53da89f Compare May 8, 2024 11:21
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 66.66%. Comparing base (3744a0a) to head (917ad19).

Files Patch % Lines
...d/core/src/modules/telemetry/services/telemetry.ts 0.00% 8 Missing ⚠️
...tend/core/src/modules/cloud/services/user-quota.ts 25.00% 3 Missing ⚠️
packages/frontend/core/src/utils/mixpanel.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@                                 Coverage Diff                                 @@
##           05-08-feat_handle_login_required_tracking_event    #6840      +/-   ##
===================================================================================
- Coverage                                            66.74%   66.66%   -0.09%     
===================================================================================
  Files                                                  583      583              
  Lines                                                27148    27160      +12     
  Branches                                              2527     2527              
===================================================================================
- Hits                                                 18121    18105      -16     
- Misses                                                8759     8787      +28     
  Partials                                               268      268              
Flag Coverage Δ
server-test 77.25% <ø> (-0.10%) ⬇️
unittest 40.22% <12.50%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 05-08-feat_handle_login_required_tracking_event branch from cc302b2 to a364280 Compare May 9, 2024 06:02
@pengx17 pengx17 force-pushed the 05-08-fix_mixpanel_issues branch from 53da89f to b7450b6 Compare May 9, 2024 06:02
@pengx17 pengx17 mentioned this pull request May 9, 2024
Copy link

graphite-app bot commented May 9, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the 05-08-feat_handle_login_required_tracking_event branch from a364280 to 3744a0a Compare May 9, 2024 07:51
@Brooooooklyn Brooooooklyn changed the base branch from 05-08-feat_handle_login_required_tracking_event to canary May 9, 2024 08:04
@graphite-app graphite-app bot merged commit 917ad19 into canary May 9, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 05-08-fix_mixpanel_issues branch May 9, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants