Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle login required tracking event #6831

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 8, 2024

No description provided.

Copy link

graphite-app bot commented May 8, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@pengx17 pengx17 marked this pull request as ready for review May 8, 2024 04:55
Copy link
Collaborator Author

pengx17 commented May 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented May 8, 2024

@pengx17 pengx17 mentioned this pull request May 8, 2024
@pengx17 pengx17 force-pushed the 05-08-feat_handle_login_required_tracking_event branch from 2de34b7 to cc302b2 Compare May 8, 2024 11:21
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.74%. Comparing base (1a9a623) to head (3744a0a).

Additional details and impacted files
@@                     Coverage Diff                      @@
##           05-09-chore_bump_blocksuite    #6831   +/-   ##
============================================================
  Coverage                        66.74%   66.74%           
============================================================
  Files                              583      583           
  Lines                            27148    27148           
  Branches                          2527     2527           
============================================================
  Hits                             18121    18121           
  Misses                            8759     8759           
  Partials                           268      268           
Flag Coverage Δ
server-test 77.34% <ø> (ø)
unittest 40.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 05-08-feat_handle_login_required_tracking_event branch from cc302b2 to a364280 Compare May 9, 2024 06:02
@pengx17 pengx17 changed the base branch from canary to 05-09-chore_bump_blocksuite May 9, 2024 06:02
@pengx17 pengx17 mentioned this pull request May 9, 2024
Copy link

graphite-app bot commented May 9, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the 05-08-feat_handle_login_required_tracking_event branch from a364280 to 3744a0a Compare May 9, 2024 07:51
@Brooooooklyn Brooooooklyn changed the base branch from 05-09-chore_bump_blocksuite to canary May 9, 2024 08:03
@graphite-app graphite-app bot merged commit 3744a0a into canary May 9, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 05-08-feat_handle_login_required_tracking_event branch May 9, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants