Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout customisation #241

Merged
merged 41 commits into from
Mar 30, 2024
Merged

Layout customisation #241

merged 41 commits into from
Mar 30, 2024

Conversation

toasterofbread
Copy link
Owner

@toasterofbread toasterofbread commented Feb 24, 2024 •
edited
Loading

Implements #229 and makes #255 redundant. Fixes part of #267 as a side-effect.

TODO

  • Portrait player top bar
  • Landscape player bottom bar (separate right and left?)
  • Require at least one primary and secondary bar
  • Remove NowPlayingMainTabActionButtons.kt
  • Music visualiser
  • Localise ja strings
  • Main custom bar list not updating on bar creation
  • Custom bar editor accent background should be fainter
  • Vertical lyrics
  • Set Android status bar colour to uppermost bar colour
  • Option to hide song feed artists row

@toasterofbread toasterofbread changed the title Begin layout customisation Layout customisation Feb 24, 2024
@toasterofbread toasterofbread mentioned this pull request Mar 11, 2024
Closed
@toasterofbread toasterofbread marked this pull request as ready for review March 22, 2024 18:47
@toasterofbread toasterofbread marked this pull request as draft March 22, 2024 18:48
@toasterofbread toasterofbread mentioned this pull request Mar 23, 2024
Closed
This was linked to issues Mar 30, 2024
Layout customisation #229
Closed
Enable/Disable top bar in music top bar should be first #255
Closed
@toasterofbread toasterofbread marked this pull request as ready for review March 30, 2024 23:25
@toasterofbread toasterofbread merged commit 8a4f6c1 into main Mar 30, 2024
4 checks passed
@toasterofbread toasterofbread deleted the layout-customisation branch March 30, 2024 23:36
This was referenced Apr 8, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable/Disable top bar in music top bar should be first Layout customisation
1 participant
@toasterofbread