Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout customisation #229

Closed
toasterofbread opened this issue Feb 9, 2024 · 0 comments · Fixed by #241
Closed

Layout customisation #229

toasterofbread opened this issue Feb 9, 2024 · 0 comments · Fixed by #241

Comments

@toasterofbread
Copy link
Owner

I've been thinking about the possibility of expanding the app's customisation options, mainly around changing how the player and main page bars are laid out.
Everything in this issue is specific to the portrait layout. These are just my initial thoughts on the idea, so feel free to discuss other ideas in this issue.

Page layout

The main app layout will be split into four re-orderable and customisable rows:

  • A: top bar, where the lyrics currently are
  • B: top bar, where song filters currently are
  • C: above the mini player
  • D: below the mini player

Several pages already follow this layout. Each page has at most two rows of its own content:

  • Song feed: mood filter row
  • Library: page selector row
  • Search page: search filter row & search bar row

Customisation

The user has four row slots available (A, B, C, D) to customise.
Two must be selected to display page content (as listed above), but the other two can display custom rows configured by the user.

Custom rows:

Rows can have large-form content displayed in the center, including lyrics and feed filters.

If a row is configured to have no center content, it can be filled with any number of center-aligned evenly-spaced buttons:

  • Settings
  • Library
  • Search
  • Radio builder
  • Etc.

If a row does have center content, it can still be given any number of buttons, but they are split between left and right (the user places each button onto the side of their choice).

@toasterofbread toasterofbread mentioned this issue Feb 24, 2024
11 tasks
@toasterofbread toasterofbread linked a pull request Mar 30, 2024 that will close this issue
11 tasks
toasterofbread added a commit that referenced this issue Mar 30, 2024
Original spec from #229 (final implementation varies):

The main app layout will be split into four re-orderable and customisable rows:

    A: top bar, where the lyrics currently are
    B: top bar, where song filters currently are
    C: above the mini player
    D: below the mini player

Several pages already follow this layout. Each page has at most two rows of its own content:

    Song feed: mood filter row
    Library: page selector row
    Search page: search filter row & search bar row

Customisation

The user has four row slots available (A, B, C, D) to customise.
Two must be selected to display page content (as listed above), but the other two can display custom rows configured by the user.
Custom rows:

Rows can have large-form content displayed in the center, including lyrics and feed filters.

If a row is configured to have no center content, it can be filled with any number of center-aligned evenly-spaced buttons:

    Settings
    Library
    Search
    Radio builder
    Etc.

If a row does have center content, it can still be given any number of buttons, but they are split between left and right (the user places each button onto the side of their choice).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant