Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure C++ compatibility for designated initialisers #167

Merged
merged 3 commits into from
Sep 17, 2021

Conversation

tlsa
Copy link
Owner

@tlsa tlsa commented Sep 17, 2021

Resolves #166.

C++ finally has designated initialisers but they still require
member order to match the definition, even though the point of
designated initilisers is to allow you to not care about order
and be explicit about specific members' values.

Reorder the members in the schema building macros to allow
them to be used from a modern enough C++ version.

C++ finally has designated initialisers but they still require
member order to match the definition, even though the point of
designated initilisers is to allow you to not care about order
and be explicit about specific members' values.

Reorder the members in the schema building macros to allow
them to be used from a modern enough C++ version.
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #167 (187117d) into main (3d234d8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   97.11%   97.11%           
=======================================
  Files           9        9           
  Lines        1596     1596           
  Branches      342      342           
=======================================
  Hits         1550     1550           
  Misses         24       24           
  Partials       22       22           
Flag Coverage Δ
unittests 97.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d234d8...187117d. Read the comment docs.

@tlsa tlsa merged commit b17eba9 into main Sep 17, 2021
@tlsa tlsa deleted the tlsa/cpp-designated-initialisers branch September 17, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example Planner does not compile
1 participant