This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
Refactor View package #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move Viiew::getRoute() to new routable behavior and make it register the 'route()' template function - Remove the 'escape' parameter from getRoute(), set the route escaping bin ViewTemplate::setUrl() - Add getContent() method to ViewContextInteface, and pass and set the content in View::getContext() - Make View class properties private and add ViewInterface::getMimetype() BREAKING! The view class properties are now private. To migrate your code use the getter methods as defined in ViewInterface
|
@ercanozkaya Can you review please ? Question: do you think we should add a View::getVersion() method to make view versioning a first class citizen of a view ? |
| if ($fqr === true) | ||
| //Determine of the url needs to be fully qualified | ||
| if($this->getMixer()->getFormat() == 'html') { | ||
| $fqe = is_bool($fqr) ? $fqr : false; |
There was a problem hiding this comment.
@johanjanssens typo here. should be $fqr
|
@johanjanssens Left two notes, good to go other than that. I wouldn't add versioning support directly to the view. It's only useful for public facing APIs and even in that case there are different takes whether or not to use versions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #75