Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

Refactor View package #75

Closed
johanjanssens opened this issue Apr 29, 2016 · 0 comments · Fixed by #76
Closed

Refactor View package #75

johanjanssens opened this issue Apr 29, 2016 · 0 comments · Fixed by #76
Labels
refactor
Milestone
v3.0.0

Comments

@johanjanssens
Copy link
Member

johanjanssens commented Apr 29, 2016 •
edited
Loading

  • Move getRoute() into a routable behaviour
  • Make ViewAbstract class properties private
  • Add getMimetype() method to ViewInterface
  • Handling route escaping transparently

Breaking changes:

  • The View class properties are now private. To migrate your code use the getter methods as defined in ViewInterface
@johanjanssens johanjanssens added this to the 3.0.0-beta.2 milestone Apr 29, 2016
johanjanssens added a commit that referenced this issue May 1, 2016
@johanjanssens
Issue #75: Refactor View
3b14965 
- Move Viiew::getRoute() to new routable behavior and make it register the 'route()' template function
- Remove the 'escape' parameter from getRoute(), set the route escaping bin ViewTemplate::setUrl()
- Add getContent() method to ViewContextInteface, and pass and set the content in View::getContext()
- Make View class properties private and add ViewInterface::getMimetype()

BREAKING! The view class properties are now private. To migrate your code use the getter methods as defined in ViewInterface
johanjanssens added a commit that referenced this issue May 1, 2016
@johanjanssens
Issue #75: Use View::getMimetype()
d63fe69
@johanjanssens johanjanssens changed the title Refactor View Refactor View package May 1, 2016
@johanjanssens johanjanssens mentioned this issue May 1, 2016
Merged
johanjanssens added a commit that referenced this issue May 2, 2016
@johanjanssens
Issue #75: Set the json output in the context
932ea40
johanjanssens added a commit that referenced this issue May 2, 2016
@johanjanssens
Issue #75: Fix typo
606ec68
johanjanssens added a commit that referenced this issue May 2, 2016
@johanjanssens
Issue #75: Pass content by reference
1ae7d37
johanjanssens added a commit that referenced this issue May 3, 2016
@johanjanssens
Issue #75: docblocks
8ae5bfe
ercanozkaya added a commit that referenced this issue Dec 27, 2018
@ercanozkaya
#75: Temporarily bring back $escape parameter to routable behavior to…
f764a82 
… keep controller routes working
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

Refactor View package timble/kodekit
1 participant
@johanjanssens