Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/fix workflow sha #807

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Chore/fix workflow sha #807

merged 2 commits into from
Jun 1, 2024

Conversation

bj00rn
Copy link
Collaborator

@bj00rn bj00rn commented May 31, 2024

fixes #806

  • checkout merge commit of PR
    • pull_request_target event default ref is base branch latest commit
  • fix broken test results image. Image is too big to be embedded in markdown.
    • use <picture> tag to link to source

@thomasnordquist I believe this is the cause of weird test results. Also I think changes above in test.yml need to be merged to master before changes take effect.

@bj00rn bj00rn added the bug Something isn't working label May 31, 2024
@bj00rn bj00rn self-assigned this May 31, 2024
@bj00rn bj00rn merged commit 3229ef5 into master Jun 1, 2024
2 checks passed
@bj00rn bj00rn deleted the chore/fix-workflow-sha branch June 1, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test.yml using wrong ref
1 participant