Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.yml using wrong ref #806

Closed
bj00rn opened this issue May 31, 2024 · 0 comments · Fixed by #807
Closed

test.yml using wrong ref #806

bj00rn opened this issue May 31, 2024 · 0 comments · Fixed by #807
Assignees
Labels
bug Something isn't working

Comments

@bj00rn
Copy link
Collaborator

bj00rn commented May 31, 2024

I believe the current test.yml workflow is using the wrong ref to test PRs. The commit actually being tested in the workflow is base branch ref since the GITHUB_REF for pull_request_target PR base branch.

The correct syntax is as follows, to check out PR head sha.

 - uses: actions/checkout@v3
     with:
          ref: ${{ github.event.pull_request.head.sha }}
      - name: Rerun on comment
@bj00rn bj00rn self-assigned this May 31, 2024
@bj00rn bj00rn added the bug Something isn't working label May 31, 2024
@bj00rn bj00rn mentioned this issue May 31, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant