Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keychron Q0 name change #2058

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Keychron Q0 name change #2058

merged 1 commit into from
Oct 22, 2023

Conversation

adophoxia
Copy link
Contributor

Description

Change file names for both, rev_0130 and rev_0131, to base and plus to reflect said file changes over on qmk/qmk_firmware.

QMK Pull Request

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22 Xelus22 merged commit 2d2d729 into the-via:master Oct 22, 2023
2 checks passed
@adophoxia adophoxia deleted the keychron-q0-name-change branch October 22, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adophoxia @Xelus22