Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Keychron Q0 #22068

Merged
merged 20 commits into from
Oct 5, 2023
Merged

Update Keychron Q0 #22068

merged 20 commits into from
Oct 5, 2023

Conversation

adophoxia
Copy link
Contributor

Description

Redo of #21994.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark requested changes Sep 19, 2023
View reviewed changes
keyboards/keychron/q0/config.h Outdated Show resolved Hide resolved
keyboards/keychron/q0/rev_0131/config.h Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team September 19, 2023 03:06
@zvecr zvecr changed the title Redo of Update Keychron Q0 Update Keychron Q0 Sep 20, 2023
dunk2k
dunk2k suggested changes Sep 20, 2023
View reviewed changes
keyboards/keychron/q0/rev_0131/readme.md Outdated Show resolved Hide resolved
keyboards/keychron/q0/readme.md Outdated Show resolved Hide resolved
keyboards/keychron/q0/rev_0130/info.json Outdated Show resolved Hide resolved
drashna
drashna reviewed Sep 21, 2023
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the revs here are encoder vs non-encoder, correct?

If so, it would be ideal to rename the folders

@adophoxia
Copy link
Contributor Author

the revs here are encoder vs non-encoder, correct?

If so, it would be ideal to rename the folders

They are. As for the folder renaming, wouldn't rlly know what to do about that since I can't use names that are shared with LAYOUT names.

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Sep 22, 2023
@drashna
Copy link
Member

drashna commented Sep 25, 2023

the revs here are encoder vs non-encoder, correct?
If so, it would be ideal to rename the folders

They are. As for the folder renaming, wouldn't rlly know what to do about that since I can't use names that are shared with LAYOUT names.

I hate to ask this, but after looking at their pages, it looks like plus and non-plus the difference is an encoder and a macro row.

for reference:
https://www.keychron.com/products/keychron-q0-qmk-custom-number-pad?_pos=2&_sid=d4acbf2a6&_ss=r
https://www.keychron.com/products/keychron-q0-plus-qmk-custom-number-pad?_pos=3&_sid=d4acbf2a6&_ss=r

To stay consistent with revision/subfolder naming elsewhere, I think that base and plus would be better naming here.

@adophoxia
Copy link
Contributor Author

To stay consistent with revision/subfolder naming elsewhere, I think that base and plus would be better naming here.

I'll take care of that right now.

@drashna
Copy link
Member

drashna commented Sep 29, 2023

sorry, I missed it, but could you add an entry for the keyboard alias json?

@adophoxia
Copy link
Contributor Author

Just got off PC. I'll add it when I can tomorrow.

@github-actions github-actions bot added the dd Data Driven Changes label Sep 30, 2023
@drashna drashna merged commit 5f33a25 into qmk:develop Oct 5, 2023
3 checks passed
@adophoxia adophoxia mentioned this pull request Oct 21, 2023
Merged
7 tasks
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@adophoxia @fauxpark
@dunk2k @mechlovin
Update Keychron Q0 (qmk#22068)
4e04faf 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@adophoxia @fauxpark
@dunk2k @christrotter
Update Keychron Q0 (qmk#22068)
9ceb97a 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@adophoxia @fauxpark
@dunk2k @zgagnon
Update Keychron Q0 (qmk#22068)
3a9cd01 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@adophoxia @fauxpark @dunk2k
Update Keychron Q0 (qmk#22068)
f222963 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
mute-civilian pushed a commit to mute-civilian/qmk_firmware that referenced this pull request Feb 17, 2024
@adophoxia @fauxpark @dunk2k
Update Keychron Q0 (qmk#22068)
ca79aa4 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
@adophoxia adophoxia deleted the keychron-q0-update-redo branch June 27, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@dunk2k dunk2k dunk2k approved these changes

Assignees
No one assigned
Labels
dd Data Driven Changes keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adophoxia @drashna @fauxpark @dunk2k