-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folders #74
Folders #74
Conversation
Signed-off-by: Sander Pick <[email protected]>
Signed-off-by: Sander Pick <[email protected]>
Signed-off-by: Sander Pick <[email protected]>
Signed-off-by: Sander Pick <[email protected]>
Signed-off-by: Sander Pick <[email protected]>
Signed-off-by: Sander Pick <[email protected]>
Signed-off-by: Sander Pick <[email protected]>
Signed-off-by: Sander Pick <[email protected]>
Signed-off-by: Sander Pick <[email protected]>
Signed-off-by: Sander Pick <[email protected]>
Signed-off-by: Sander Pick <[email protected]>
Path: "Path", | ||
}, { | ||
Path: "Name", | ||
Unique: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A project can only have one folder by a given name. Question: Maybe we can use "bucket" instead of "folder"? Too close to S3?
Signed-off-by: Sander Pick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! 💯
I left some questions and comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much to add considering @jsign's thorough review. Looking forward to reading the replies on his comments. Looks good in general.
Signed-off-by: Sander Pick <[email protected]>
Thanks for the review, guys! I've addresses or created issues for the relevant comments. |
Closes #68 (different implementation than originally expected)
Closes #69 (different implementation than originally expected)
This adds folder handling to the Files API, which involved removing the
Files
collection and theFile
model in place ofFolders
and aFolder
model. Files are handled under the hood by the IPFS Files API. Folders are just IPFS Directories.Demos
Next Steps
This PR adds some low-ish-level APIs and commands for managing files and folder. Next, I'd like to add some higher level commands for syncing folders (these may require some merge handling, not sure yet):
textile push <folder>
(push latest)textile pull <folder>
(pull whatever the remote has)