Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Update cid package #243

Merged
merged 3 commits into from
Feb 7, 2020
Merged

Deps: Update cid package #243

merged 3 commits into from
Feb 7, 2020

Conversation

sanderpick
Copy link
Member

Signed-off-by: Sander Pick <[email protected]>
Signed-off-by: Sander Pick <[email protected]>
Copy link
Contributor

@jsign jsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I took the chance to re-run the tests twice but still failing. Make sense to you?

@sanderpick
Copy link
Member Author

Should be good now with 5b3d35f. Some sentinel error in the cid package was replaced with something similar in a varint package that we needed to catch... 🤷‍♂

@sanderpick
Copy link
Member Author

I'm not sure what's up with DCO not finishing but I'll merge anyway.

@sanderpick sanderpick merged commit d3f681e into master Feb 7, 2020
@sanderpick sanderpick deleted the sander/update-cid branch February 7, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants