Fix golangci-lint issues

Signed-off-by: Vincent Demeester <[email protected]>

Backport release "scripts" changes from main…

… as we switch to ghcr.io, we need those to be updated to work as they
are referered during releases.

Signed-off-by: Vincent Demeester <[email protected]>

Backport release "scripts" changes from main…

… as we switch to ghcr.io, we need those to be updated to work as they
are referered during releases.

Signed-off-by: Vincent Demeester <[email protected]>

Backport release "scripts" changes from main…

… as we switch to ghcr.io, we need those to be updated to work as they
are referered during releases.

Signed-off-by: Vincent Demeester <[email protected]>

Backport release "scripts" changes from main…

… as we switch to ghcr.io, we need those to be updated to work as they
are referered during releases.

Signed-off-by: Vincent Demeester <[email protected]>

build(deps): bump github.com/Azure/azure-sdk-for-go/sdk/azidentity

Bumps [github.com/Azure/azure-sdk-for-go/sdk/azidentity](https://github.com/Azure/azure-sdk-for-go) from 1.5.2 to 1.6.0.
- [Release notes](https://github.com/Azure/azure-sdk-for-go/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md)
- [Commits](Azure/azure-sdk-for-go@sdk/internal/v1.5.2...sdk/azcore/v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azidentity
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Fix Artifact type to a pointer

Prior to this, the Artifacts in TaskRunStatusFields was not set to
a pointer of the underlying struct. As a result, it was incompatible
with `tkn`. Here we fix that issue by updating it to a `pointer`.

(cherry picked from commit c910594)
Signed-off-by: Vincent Demeester <[email protected]>

Fix Artifact type to a pointer

Prior to this, the Artifacts in TaskRunStatusFields was not set to
a pointer of the underlying struct. As a result, it was incompatible
with `tkn`. Here we fix that issue by updating it to a `pointer`.

check namespace config for node throttle metric

Now that @vdemeester 's fix so that the background metric polling goroutines for pipelinerunmetrics and taskrunmetrics can access config.observability, we can properly address issue around verifiying non-default config around adding the namespace label for the node and quota throttle metrics that @divyansh42 @khrm and myself discovered last week.

Signed-off-by: gabemontero <[email protected]>

rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED

Refine check if the result is from a matrix task

Given a matrix run of a TaskRun with cardinality of 1, the result from
it will not be converted to an array but kept as a string, i.e. as if
the TaskRun was not configured to run with matrix.

This causes issues for consumers of the TaskRun's results as they will
be configured to consume array results. As a result making the passed
value equal to expression value instead.

Resolves: #8157