Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Lightning CSS in the PostCSS Plugin #10399

Merged
merged 11 commits into from
Jan 23, 2023
Merged

Use Lightning CSS in the PostCSS Plugin #10399

merged 11 commits into from
Jan 23, 2023

Commits on Jan 23, 2023

  1. bump lightningcss

    @RobinMalfait
    RobinMalfait committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    bcfb9bc View commit details
    Browse the repository at this point in the history

  2. use lightningcss in the main PostCss Plugin

    @RobinMalfait
    RobinMalfait committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    e69bf02 View commit details
    Browse the repository at this point in the history

  3. use lightningcss in our custom matchers 

    Now that we are using `lightningcss` and nesting in the new `oxide`
engine, the generated output _will_ be different in the majority of test
cases.

Using a combination of `prettier` and `lightningcss` will make the
output consistent.

The moment we are fully using the `oxide` engine, we can drop
`lightningcss` or `prettier` again to improve the performance of the
tests.
    @RobinMalfait
    RobinMalfait committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    c753630 View commit details
    Browse the repository at this point in the history

  4. update tests to apply lightningcss related changes

    @RobinMalfait
    RobinMalfait committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    46a0f4b View commit details
    Browse the repository at this point in the history

  5. update changelog

    @RobinMalfait
    RobinMalfait committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    6a55634 View commit details
    Browse the repository at this point in the history

  6. add lightningcss and browserslist as dev dependencies to stable p… 

    …ackage.json
    @RobinMalfait
    RobinMalfait committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    2ec25d1 View commit details
    Browse the repository at this point in the history

  7. only use lightningcss in tests (without prettier) 

    We will only fallback to prettier if lightningcss fails somehow.
    @RobinMalfait
    RobinMalfait committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    66c0bc6 View commit details
    Browse the repository at this point in the history

  8. apply side effect chagnes due to only using lightningcss for tests

    @RobinMalfait
    RobinMalfait committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    7411da3 View commit details
    Browse the repository at this point in the history

  9. make CI happy (integration tests) 

    Apply changes to integration tests now that we are using lightningcss
    @RobinMalfait
    RobinMalfait committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    9247100 View commit details
    Browse the repository at this point in the history

  10. transform lightningcss for Node 12 when running tests

    @RobinMalfait
    RobinMalfait committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    df1a93e View commit details
    Browse the repository at this point in the history

  11. run prettier on failing tests for toMatchFormattedCss 

    This will result in better diffs because diffs are typically per block
and/or per line. But lightningcss will simplify certain selectors and
the diff won't be as clear.

We will only apply the prettier formatting for failing tests in the diff
view so that diffs are cleaner and we don't pay for the additional
prettier calls when tests pass.
    @RobinMalfait
    RobinMalfait committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    7227d0f View commit details
    Browse the repository at this point in the history