Use Lightning CSS
in the PostCSS
Plugin
#10399
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add
Lightning CSS
to thePostCSS
Plugin in theoxide
engine. This also required alittle bit of fiddling around with tests because the
stable
version doesn't use that.To solve this, we will run both version through
Lightning CSS
but purely in tests to get the sameoutput. It technically makes things a bit slower (but only in tests) and they are now also
consistent.
There is a confusing part though, if you use something like this:
Then the test will pass, but logging the
output
could look like:Not sure if this is an actual problem right now or not...