Improve detection of string concatenation #288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd check to see if a string literal was immediately nested inside a concat expression, for example:
However, this breaks down when the strings being sorted are nested inside other expressions. For example, a ternary expression:
The way this works is if a string is nested inside a concat expression at any level then we'll do our best to keep the relevant whitespace. Obviously, due to runtime evaluation, we can't guarantee that all necessary whtiespace will be preserved, or that all unnecessary whitespace will be removed, but this improves the situation for the vast majority of cases.
Fixes #285
This depends on #287 and that PR must be merged first