Convert to typescript #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn’t seem to actually have any side-effects but typescript has revealed possible issues here
Can’t use it to bundle just yet
Worth seeing if it makes things faster
RobinMalfait
reviewed
Jun 7, 2024
Probably isn’t any reason for this actually
RobinMalfait
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a lot of types and stuff to improve but I've wanted to land this change for quite some time. Now seems like a good time to do it 😄
A few notes:
type: module— it was already ESM only but some internal scripts used CJS. I think this is a good time to change all of that over