Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reapply style fixes on tw pages #189

Merged
merged 5 commits into from
Jul 15, 2022
Merged

fix: reapply style fixes on tw pages #189

merged 5 commits into from
Jul 15, 2022

Conversation

CarlosGomez-dev
Copy link
Contributor

Reapply style fixes on tw pages

  • I reviewed linter warnings + errors, resolved formatting, types and other issues related to my work
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

#178 removed the style fixes done in #148 and #151, and gave all tw pages the same cards.

This PR reapplies the style fixes and restores the original cards.


Copy link
Member

@nexxeln nexxeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please put the component below the page component

template/page-studs/index/with-auth-trpc-tw.tsx Outdated Show resolved Hide resolved
@nexxeln
Copy link
Member

nexxeln commented Jul 15, 2022

Thank you!

@nexxeln nexxeln merged commit af1067b into t3-oss:main Jul 15, 2022
@CarlosGomez-dev CarlosGomez-dev deleted the fix/home-styles branch July 15, 2022 14:04
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
* Revert "fix: use components for the tech within the splash screen (t3-oss#178)"

This reverts commit c436382.

* refactor: add TechnologyCard component

* fix: place technology card component after home

* fix: remove brackets from strings

Co-authored-by: Shoubhit Dash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants