fix: use components for the tech within the splash screen #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nexxeln
requested changes
Jul 12, 2022
|
Looks good to me. Will fix the CI and merge. Thanks! |
This was referenced Jul 14, 2022
nexxeln
added a commit
that referenced
this pull request
Jul 15, 2022
* Revert "fix: use components for the tech within the splash screen (#178)" This reverts commit c436382. * refactor: add TechnologyCard component * fix: place technology card component after home * fix: remove brackets from strings Co-authored-by: Shoubhit Dash <[email protected]>
devvianto605
pushed a commit
to devvianto605/create-devviantex-nextjs-app-deprecated
that referenced
this pull request
Jun 9, 2024
* fix: use components for the tech within the splash screen * chore: run prettier * fix: change tech prop name
devvianto605
pushed a commit
to devvianto605/create-devviantex-nextjs-app-deprecated
that referenced
this pull request
Jun 9, 2024
* Revert "fix: use components for the tech within the splash screen (t3-oss#178)" This reverts commit c436382. * refactor: add TechnologyCard component * fix: place technology card component after home * fix: remove brackets from strings Co-authored-by: Shoubhit Dash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Componentize landing page
This pull request makes the landing page use a component for each technology that the stack uses, rather than 4 long chunks of JSX. I believe this would make the landing page code cleaner, and easier to read. As well as give new people a sense for how components work; if they haven't used React or Typescript with React before.