Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: skip http for trpc rsc calls #1670

Merged
merged 9 commits into from
Nov 21, 2023
Merged

feat: skip http for trpc rsc calls #1670

merged 9 commits into from
Nov 21, 2023

Conversation

juliusmarminge
Copy link
Member

@juliusmarminge juliusmarminge commented Nov 19, 2023 •
edited

Closes #1669
Closes #1656
Closes #1650
Closes #1639
Closes #1599

Adds a custom link that just invokes the procedures directly with a cached createContext function, instead of using http even for RSC which is unnecessary

@vercel Vercel
Copy link

vercel bot commented Nov 19, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
t3-upgrade ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 10:44pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
create-t3-app ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 10:44pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2023 •
edited

🦋 Changeset detected

Latest commit: 02ffc2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This was referenced Nov 19, 2023
Merged
Merged
@juliusmarminge
Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@juliusmarminge juliusmarminge mentioned this pull request Nov 19, 2023
Closed
@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Nov 19, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2023 •
edited

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 64
🟢 Accessibility 91
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-git-11-19-skiphttpforrsctrpccalls-t3-oss.vercel.app/

@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 19, 2023
@juliusmarminge
Copy link
Member Author

juliusmarminge commented Nov 19, 2023 •
edited

Latest beta:

pnpm create [email protected]

@juliusmarminge juliusmarminge force-pushed the 11-19-skip_http_for_rsc_trpc_calls branch from 64b92d3 to 3e15d47 Compare November 19, 2023 10:27
Base automatically changed from 11-18-bump_deps to main November 19, 2023 12:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2023 •
edited

A new create-t3-app prerelease is available for testing. You can install this latest build in your project with:

pnpm create [email protected]

@juliusmarminge juliusmarminge force-pushed the 11-19-skip_http_for_rsc_trpc_calls branch from 869edb7 to d60d4f7 Compare November 19, 2023 13:02
@juliusmarminge juliusmarminge added 🚀 autorelease add this label to a pr to trigger a beta release and removed 🚀 autorelease add this label to a pr to trigger a beta release labels Nov 19, 2023
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 19, 2023
c-ehrlich
c-ehrlich approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits but happy to merge as is

cli/template/extras/src/trpc/server.ts Show resolved Hide resolved
cli/template/extras/src/trpc/server.ts Outdated Show resolved Hide resolved
cli/template/extras/src/trpc/server.ts Show resolved Hide resolved
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 20, 2023
@juliusmarminge juliusmarminge added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit 32e0747 Nov 21, 2023
75 checks passed
@juliusmarminge juliusmarminge deleted the 11-19-skip_http_for_rsc_trpc_calls branch November 21, 2023 22:49
@github-actions github-actions bot mentioned this pull request Nov 19, 2023
Merged
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@juliusmarminge
feat: skip http for trpc rsc calls (t3-oss#1670)
046ab8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eula01 eula01 eula01 left review comments

@c-ehrlich c-ehrlich c-ehrlich approved these changes

@nexxeln nexxeln Awaiting requested review from nexxeln nexxeln is a code owner

@t3dotgg t3dotgg Awaiting requested review from t3dotgg t3dotgg is a code owner

Assignees
No one assigned
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 🚀 autorelease add this label to a pr to trigger a beta release
Projects
None yet
Milestone
No milestone
3 participants
@juliusmarminge @c-ehrlich @eula01