Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use type: module #1666

Merged
merged 7 commits into from
Nov 19, 2023
Merged

refactor: use type: module #1666

merged 7 commits into from
Nov 19, 2023

Conversation

juliusmarminge
Copy link
Member

@juliusmarminge juliusmarminge commented Nov 18, 2023

imo every project in 2023 should use type: module

Soon we will have an ESM eslint.config.js file and then it's just postcss left in cjs land...

Copy link

vercel bot commented Nov 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
t3-upgrade ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2023 9:42pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
create-t3-app ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2023 9:42pm

Copy link

changeset-bot bot commented Nov 18, 2023

🦋 Changeset detected

Latest commit: f8943b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juliusmarminge
Copy link
Member Author

juliusmarminge commented Nov 18, 2023

@github-actions github-actions bot added 📚 documentation Improvements or additions to documentation 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Nov 18, 2023
Copy link
Contributor

github-actions bot commented Nov 18, 2023

Hey t3-oss/translators!

This PR contains changes to your language. Please review the changes ❤️.

Copy link
Contributor

github-actions bot commented Nov 18, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 99
🟢 Accessibility 91
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-git-11-18-usetypemodule-t3-oss.vercel.app/

@juliusmarminge
Copy link
Member Author

juliusmarminge commented Nov 19, 2023

Merge activity

@juliusmarminge juliusmarminge merged commit 3317a41 into main Nov 19, 2023
76 checks passed
@juliusmarminge juliusmarminge deleted the 11-18-use_type_module branch November 19, 2023 12:57
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
imo every project in 2023 should use `type: module`

Soon we will have an ESM `eslint.config.js` file and then it's just postcss left in cjs land...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants