Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reverted incorrect fixes, fixed landing page cmd #1624

Merged
merged 8 commits into from
Oct 25, 2023
Merged

fix: Reverted incorrect fixes, fixed landing page cmd #1624

merged 8 commits into from
Oct 25, 2023

Conversation

AndehUK
Copy link
Contributor

@AndehUK AndehUK commented Oct 25, 2023

Closes #1620

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Reverts all incorrect changes in #1621 and changes the displayed npx command in banner.astro from npx create t3-app@latest to npm create t3-app@latest

Screenshots

Before:

image

After:

image

💯

ed-wright and others added 4 commits October 24, 2023 21:20
@ed-wright
fix: replace all incorrect versions
4d5cb5a 
goes through the repo and replaces all incorrect versions of create t3-app with  create-t3-app
This closes 1620
@ed-wright
chore: add changeset
df368ad
@AndehUK
Reverted incorrect fixes, fixed landing page cmd
6f3089a
@AndehUK
Remove unneeded .changeset md file
1e361e4
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: df4cfea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 5:38pm

@vercel
Copy link

vercel bot commented Oct 25, 2023

@AndehUK is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Oct 25, 2023
@AndehUK AndehUK changed the title Fix: Reverted incorrect fixes, fixed landing page cmd fix: Reverted incorrect fixes, fixed landing page cmd Oct 25, 2023
Jacksonmills
Jacksonmills suggested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@Jacksonmills Jacksonmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the label fix on homepage, don't need the command changes.

www/src/components/landingPage/ClipboardSelect.tsx Outdated Show resolved Hide resolved
@AndehUK
Copy link
Contributor Author

AndehUK commented Oct 25, 2023

Accidentally left an ESLint comment in there which I have now removed, as I posted in the discord server eslint and my local config aren't agreeing with each other at the minute.

https://discord.com/channels/966627436387266600/988912020558602331/1166769760386691154

c-ehrlich
c-ehrlich approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@c-ehrlich c-ehrlich mentioned this pull request Oct 25, 2023
Closed
@c-ehrlich c-ehrlich added this pull request to the merge queue Oct 25, 2023
Merged via the queue into t3-oss:next with commit af6f947 Oct 25, 2023
8 of 10 checks passed
@AndehUK AndehUK deleted the feature/fix-incorrect-npx branch October 25, 2023 18:46
@AndehUK AndehUK restored the feature/fix-incorrect-npx branch October 25, 2023 18:46
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
@AndehUK @ed-wright
fix: Reverted incorrect fixes, fixed landing page cmd (t3-oss#1624)
5949f9e 
Co-authored-by: Edward Wright <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacksonmills Jacksonmills Jacksonmills requested changes

@c-ehrlich c-ehrlich c-ehrlich approved these changes

@juliusmarminge juliusmarminge Awaiting requested review from juliusmarminge

@nexxeln nexxeln Awaiting requested review from nexxeln

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

Assignees
No one assigned
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: create.t3.gg npx link is incorrect
4 participants
@AndehUK @c-ehrlich @Jacksonmills @ed-wright