-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace all incorrect versions #1621
Conversation
goes through the repo and replaces all incorrect versions of create t3-app with create-t3-app This closes 1620
🦋 Changeset detectedLatest commit: df368ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@ed-wright is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
Hey t3-oss/translators! This PR contains changes to your language. Please review the changes ❤️. AR: @a4addel, @Sboonny | ES: | FR: @Defranos, @joachimjusth, @vdeva | JA: @t6adev, @uehaj | NO: @estubmo, @josephayman | PL: @matibox, @Infiplaya, @PiotrekPKP | PT: @minsk-dev, @Sn0wye, @victoriaquasar, @MattFerreira18, @gilhrpenner | RU: @AmadeusTwi, @ronanru, @JohnBakhmat | ZH-HANS: @fernandoxu, @escwxyz |
You fixed one wrong install command, but broke all others.
The only wrong install command was in the banner. (should be npm instead of npx). Also, you don't need a changeset for this change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr. The command in banner.astro
is indeed incorrect. But all the other commands are correct as they are, and the way you changed them (npm create-t3-app
etc) are not valid commands.
npm create
, and the equivalent yarn/pnpm/bunx commands) are a real thing, see: https://docs.npmjs.com/cli/v9/commands/npm-init
Could you change the PR to only fix the one on the landing page, and revert the others?
@@ -73,7 +73,7 @@ import ClipboardSelect from "./ClipboardSelect"; | |||
<div | |||
class="relative flex items-center rounded-lg border border-t3-purple-200/20 bg-t3-purple-100/10 px-2 py-2 text-sm md:px-3 md:py-3 md:text-lg lg:px-5 lg:py-4 lg:text-xl" | |||
> | |||
<code class="mr-12">npx create t3-app@latest</code> | |||
<code class="mr-12">npx create-t3-app@latest</code> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is indeed incorrect - seems to have been missed when #1612 was reviewed. but personally I think it would be better to stay consistent and use npm create
here, as it's what we're doing everywhere else.
<code class="mr-12">npx create-t3-app@latest</code> | |
<code class="mr-12">npm create t3-app@latest</code> |
superseded by #1624 |
goes through the repo and replaces all incorrect versions of create t3-app with create-t3-app This closes 1620
Closes #1620
✅ Checklist
Changelog
All incorrect versions of the npx command have been replaced
Screenshots
Old
New
💯