Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace all incorrect versions #1621

Closed
wants to merge 2 commits into from

Conversation

ed-wright
Copy link
Contributor

goes through the repo and replaces all incorrect versions of create t3-app with create-t3-app This closes 1620

Closes #1620

✅ Checklist

  • [✅] I have followed every step in the contributing guide (updated 2022-10-06).
  • [✅ ] The PR title follows the convention we established conventional-commit
  • [✅ ] I performed a functional test on my final commit

Changelog

All incorrect versions of the npx command have been replaced


Screenshots

Old
image
New
image

💯

goes through the repo and replaces all incorrect versions of create t3-app with  create-t3-app
This closes 1620
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: df368ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 8:29pm

@vercel
Copy link

vercel bot commented Oct 24, 2023

@ed-wright is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added 📚 documentation Improvements or additions to documentation 📌 area: cli Relates to the CLI 📌 area: ci Relates to CI / GitHub Actions labels Oct 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Hey t3-oss/translators!

This PR contains changes to your language. Please review the changes ❤️.

AR: @a4addel, @Sboonny | ES: | FR: @Defranos, @joachimjusth, @vdeva | JA: @t6adev, @uehaj | NO: @estubmo, @josephayman | PL: @matibox, @Infiplaya, @PiotrekPKP | PT: @minsk-dev, @Sn0wye, @victoriaquasar, @MattFerreira18, @gilhrpenner | RU: @AmadeusTwi, @ronanru, @JohnBakhmat | ZH-HANS: @fernandoxu, @escwxyz

@ronanru
Copy link
Contributor

ronanru commented Oct 24, 2023

You fixed one wrong install command, but broke all others.
Correct install commands are

  • npm create t3-app@latest
  • yarn create t3-app@latest
  • pnpm create t3-app@latest
  • bun create t3-app@latest

npm create thing is the same as npx create-thing
https://docs.npmjs.com/cli/v8/commands/npm-init

The only wrong install command was in the banner. (should be npm instead of npx).

Also, you don't need a changeset for this change

Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr. The command in banner.astro is indeed incorrect. But all the other commands are correct as they are, and the way you changed them (npm create-t3-app etc) are not valid commands.

npm create, and the equivalent yarn/pnpm/bunx commands) are a real thing, see: https://docs.npmjs.com/cli/v9/commands/npm-init

Could you change the PR to only fix the one on the landing page, and revert the others?

@@ -73,7 +73,7 @@ import ClipboardSelect from "./ClipboardSelect";
<div
class="relative flex items-center rounded-lg border border-t3-purple-200/20 bg-t3-purple-100/10 px-2 py-2 text-sm md:px-3 md:py-3 md:text-lg lg:px-5 lg:py-4 lg:text-xl"
>
<code class="mr-12">npx create t3-app@latest</code>
<code class="mr-12">npx create-t3-app@latest</code>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is indeed incorrect - seems to have been missed when #1612 was reviewed. but personally I think it would be better to stay consistent and use npm create here, as it's what we're doing everywhere else.

Suggested change
<code class="mr-12">npx create-t3-app@latest</code>
<code class="mr-12">npm create t3-app@latest</code>

@c-ehrlich
Copy link
Member

superseded by #1624

@c-ehrlich c-ehrlich closed this Oct 25, 2023
@ed-wright ed-wright deleted the feature/fix-incorrect-npx branch October 25, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: ci Relates to CI / GitHub Actions 📌 area: cli Relates to the CLI 📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: create.t3.gg npx link is incorrect
3 participants