Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): start any example in stackblitz #1576

Merged
merged 13 commits into from
Oct 6, 2023
Merged

Conversation

mqshaikh8
Copy link
Contributor

Closes #

✅ Checklist

  • [✅] I have followed every step in the contributing guide (updated 2022-10-06).
  • [✅] The PR title follows the convention we established conventional-commit
  • [✅] I performed a functional test on my final commit

Changelog

I added an example page that lets users pick the different options and see how it would work on stackblitz.


Screenshots

[Screenshots]
Screen Shot 2023-09-25 at 8 17 19 AM

💯

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

⚠️ No Changeset found

Latest commit: 7e9541e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 8:47am

@vercel
Copy link

vercel bot commented Sep 25, 2023

@mqshaikh8 is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pr. this is a really clever way of implementing the demos :)

www/src/components/docs/exampleOptionForm.astro Outdated Show resolved Hide resolved
www/src/components/docs/exampleOptionForm.astro Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated Show resolved Hide resolved
@mqshaikh8
Copy link
Contributor Author

Hi,
It was a straightforward fix so I just added it in here. I also added a callout just to make sure the prisma and drizzle check switching is understood.

www/src/components/docs/exampleOptionForm.astro Outdated Show resolved Hide resolved
www/src/pages/en/examples.mdx Outdated Show resolved Hide resolved
@mqshaikh8
Copy link
Contributor Author

@juliusmarminge I decided to add another callout to cover that. I also am not able to get rod of the pnpm changes. I downgraded to 8.5.

@mqshaikh8
Copy link
Contributor Author

@c-ehrlich @juliusmarminge Let me know if there are other changes I should do.

Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. It's not starting up the example automatically for me though:

CleanShot 2023-10-06 at 10 48 42@2x

If you wanna look into that as a follow-up PR that would be great, but no pressure as this is perfectly fine!

Maybe also use PNPM over NPM, I think Stackblitz got that installed by default?

@juliusmarminge juliusmarminge changed the title Feat: Added option for users to try out different combinations on stackblitz feat(docs): start any example in stackblitz Oct 6, 2023
@juliusmarminge juliusmarminge added this pull request to the merge queue Oct 6, 2023
Merged via the queue into t3-oss:next with commit 3d74370 Oct 6, 2023
7 of 9 checks passed
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants