-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RFC): sync example apps to separate repos #1126
Comments
For this we would first have to create different repos for all the individual repositories and then we can git subtree them down right? |
Nope - haven't created them yet but that can be done if someone takes a stab at it |
I can pick this but repos should be created as i won't have the access to that! |
Lets try first with just having them in the monorepo and see if we need separate repos for them later? |
Sure |
Hey y'all, |
this is from half a year ago, so feel free to pick it up. |
Hey @juliusmarminge , |
The initial plan was probably to have them generated inside the repo which would allow us to easily share stackblitz links like https://stackblitz.com/github/t3-oss/create-t3-app/tree/main/examples/with-drizzle-trpc-tailwind or something |
I just wanted to kind of generate a a sample, I am going to fork the repo and create those examples there. |
Hi @juliusmarminge, |
Hi @juliusmarminge, |
Should I close this? I am not sure what the process is @juliusmarminge |
Is your feature request related to a problem? Please describe.
Currently, we have https://t3.new which opens a fresh t3-app in Codesandbox - but it doesn't sync up to new releases.
I'm thinking we could build some apps automatically on each release that would then be subtree'd down to separate repos which could then be forked on CodeSandbox / Stackblitz. It would also make it quite easy to browse how a t3-app looks without needing to run the CLI.
Describe the solution you'd like to see
I think we'd need to have each app in the main monorepo workspace like
examples/*
and then when we publish new releases, git subtree them down to separate repos so that they are kept up to date.tRPC does something similar:
Workspace: https://github.com/trpc/trpc/tree/main/examples/next-minimal-starter
Subtree workflow: https://github.com/trpc/trpc/blob/main/.github/workflows/subtree.yml
Repo: https://github.com/trpc/examples-next-minimal-starter
Then, we could update the
https://t3.new
to accept some query params for what packages you would like to use and it would launch that repo in CodeSandbox/Stackblitz accordingly:https://t3.new?prisma&next-auth
https://t3.new?prisma&trpc&tailwind
Describe alternate solutions
Technically, we wouldn't need both example workspaces and separate repos - but I'm unsure how to do one without the other? We could only do workspace and launch Stackblitz from the example/* directory - although then they wouldn't have lockfiles which would cause long installation times 🤔
Open to suggestions on the implementation.
Additional information
I think we can switch to Stackblitz since the swc issue seems to be fixed there now.
The text was updated successfully, but these errors were encountered: