chore: T3-upgrade - remove metadataBase + add default og image #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@andreifilip123 is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://create-t3-app-git-fork-andreifilip123-t3-upgrade-t3-oss.vercel.app/ |
andreifilip123
requested review from
juliusmarminge,
nexxeln,
t3dotgg and
c-ehrlich
as code owners
andreifilip123
changed the title
juliusmarminge
added a commit
that referenced
this pull request
May 25, 2023
* feat: Add upgrade/changelog code (#1420) * Init t3 app * Install shadcn/ui * Add required shadcn/ui components * feat: Add code for * Move octokit inside function * Get more releases * initial workspace config * format and lint * specify eslint paths * some ui changes * ui * lift some state to url * layout fix * theming * favicon * fixy * filter out versions we don't have * sync * uniform function vs const * fix filter --------- Co-authored-by: juliusmarminge <[email protected]> * Update README.md * fix styles * expand 1st item by default * importatn?? * rm filter * fix: Minor fixes (#1426) * add a loader * revert force dymaic * fixy * fixy2 * Button -> Link * fix favicon * fixy * rm unnecessary abstraction * feat: Dynamic og image (#1435) * Add og image (screenshot) (#1434) * fix: Add missing versions that were excluded because they contain 0's in them (#1447) * Add og image (screenshot) * fix: getT3Versions was ignoring versions with a 0 in them * chore: tweak some t3-upgrade og styles (#1445) * little bit of a tweak * 👋 * twitter tags * Update route.tsx * Merge branch 'next' into t3-upgrade * chore: T3-upgrade - remove metadataBase + add default og image (#1448) * Add og image (screenshot) * fix: getT3Versions was ignoring versions with a 0 in them * Add back base og image * Remove metadata base * fixup * fix turbo pipelie --------- Co-authored-by: Andrei Filip <[email protected]> Co-authored-by: Finn <[email protected]>
devvianto605
pushed a commit
to devvianto605/create-devviantex-nextjs-app
that referenced
this pull request
Jun 9, 2024
* feat: Add upgrade/changelog code (t3-oss#1420) * Init t3 app * Install shadcn/ui * Add required shadcn/ui components * feat: Add code for * Move octokit inside function * Get more releases * initial workspace config * format and lint * specify eslint paths * some ui changes * ui * lift some state to url * layout fix * theming * favicon * fixy * filter out versions we don't have * sync * uniform function vs const * fix filter --------- Co-authored-by: juliusmarminge <[email protected]> * Update README.md * fix styles * expand 1st item by default * importatn?? * rm filter * fix: Minor fixes (t3-oss#1426) * add a loader * revert force dymaic * fixy * fixy2 * Button -> Link * fix favicon * fixy * rm unnecessary abstraction * feat: Dynamic og image (t3-oss#1435) * Add og image (screenshot) (t3-oss#1434) * fix: Add missing versions that were excluded because they contain 0's in them (t3-oss#1447) * Add og image (screenshot) * fix: getT3Versions was ignoring versions with a 0 in them * chore: tweak some t3-upgrade og styles (t3-oss#1445) * little bit of a tweak * 👋 * twitter tags * Update route.tsx * Merge branch 'next' into t3-upgrade * chore: T3-upgrade - remove metadataBase + add default og image (t3-oss#1448) * Add og image (screenshot) * fix: getT3Versions was ignoring versions with a 0 in them * Add back base og image * Remove metadata base * fixup * fix turbo pipelie --------- Co-authored-by: Andrei Filip <[email protected]> Co-authored-by: Finn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the metadataBase field since the default is good enough. Added back missing base og image
https://nextjs.org/docs/app/api-reference/functions/generate-metadata#default-value