Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add og image (screenshot) #1434

Merged
merged 1 commit into from
May 21, 2023

Conversation

andreifilip123
Copy link
Contributor

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

[Short description of what has changed]


Screenshots

[Screenshots]

💯

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2023

⚠️ No Changeset found

Latest commit: c44499e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 7:06pm

@vercel
Copy link

vercel bot commented May 19, 2023

@andreifilip123 is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-git-fork-andreifilip123-t3-upgrade-t3-oss.vercel.app/

@andreifilip123
Copy link
Contributor Author

@juliusmarminge juliusmarminge merged commit f382886 into t3-oss:t3-upgrade May 21, 2023
6 of 8 checks passed
juliusmarminge added a commit that referenced this pull request May 25, 2023
* feat: Add upgrade/changelog code (#1420)

* Init t3 app

* Install shadcn/ui

* Add required shadcn/ui components

* feat: Add code for

* Move octokit inside function

* Get more releases

* initial workspace config

* format and lint

* specify eslint paths

* some ui changes

* ui

* lift some state to url

* layout fix

* theming

* favicon

* fixy

* filter out versions we don't have

* sync

* uniform function vs const

* fix filter

---------

Co-authored-by: juliusmarminge <[email protected]>

* Update README.md

* fix styles

* expand 1st item by default

* importatn??

* rm filter

* fix: Minor fixes (#1426)

* add a loader

* revert force dymaic

* fixy

* fixy2

* Button -> Link

* fix favicon

* fixy

* rm unnecessary abstraction

* feat: Dynamic og image (#1435)

* Add og image (screenshot) (#1434)

* fix: Add missing versions that were excluded because they contain 0's in them (#1447)

* Add og image (screenshot)

* fix: getT3Versions was ignoring versions with a 0 in them

* chore: tweak some t3-upgrade og styles (#1445)

* little bit of a tweak

* 👋

* twitter tags

* Update route.tsx

* Merge branch 'next' into t3-upgrade

* chore: T3-upgrade - remove metadataBase + add default og image (#1448)

* Add og image (screenshot)

* fix: getT3Versions was ignoring versions with a 0 in them

* Add back base og image

* Remove metadata base

* fixup

* fix turbo pipelie

---------

Co-authored-by: Andrei Filip <[email protected]>
Co-authored-by: Finn <[email protected]>
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
* feat: Add upgrade/changelog code (t3-oss#1420)

* Init t3 app

* Install shadcn/ui

* Add required shadcn/ui components

* feat: Add code for

* Move octokit inside function

* Get more releases

* initial workspace config

* format and lint

* specify eslint paths

* some ui changes

* ui

* lift some state to url

* layout fix

* theming

* favicon

* fixy

* filter out versions we don't have

* sync

* uniform function vs const

* fix filter

---------

Co-authored-by: juliusmarminge <[email protected]>

* Update README.md

* fix styles

* expand 1st item by default

* importatn??

* rm filter

* fix: Minor fixes (t3-oss#1426)

* add a loader

* revert force dymaic

* fixy

* fixy2

* Button -> Link

* fix favicon

* fixy

* rm unnecessary abstraction

* feat: Dynamic og image (t3-oss#1435)

* Add og image (screenshot) (t3-oss#1434)

* fix: Add missing versions that were excluded because they contain 0's in them (t3-oss#1447)

* Add og image (screenshot)

* fix: getT3Versions was ignoring versions with a 0 in them

* chore: tweak some t3-upgrade og styles (t3-oss#1445)

* little bit of a tweak

* 👋

* twitter tags

* Update route.tsx

* Merge branch 'next' into t3-upgrade

* chore: T3-upgrade - remove metadataBase + add default og image (t3-oss#1448)

* Add og image (screenshot)

* fix: getT3Versions was ignoring versions with a 0 in them

* Add back base og image

* Remove metadata base

* fixup

* fix turbo pipelie

---------

Co-authored-by: Andrei Filip <[email protected]>
Co-authored-by: Finn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants