Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added an option for prettier and a extended eslint config #1425

Merged

Conversation

FinnDore
Copy link
Contributor

Closes #1332

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

[Short description of what has changed]


Screenshots

[Screenshots]

💯

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2023

⚠️ No Changeset found

Latest commit: 5a70c19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 6:49pm

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-git-fork-finndore-prettier-import-order-t3-oss.vercel.app/

@FinnDore
Copy link
Contributor Author

prev #1392

@FinnDore
Copy link
Contributor Author

Was bussy today but ive got to actually test this again since we moved them to a secondary prompt

@vercel
Copy link

vercel bot commented May 18, 2023

@FinnDore is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@FinnDore
Copy link
Contributor Author

Merged from upstream/next into this branch. think this is good now. I asume the e2e tests are not running because im not cool enough and not that ive broken them

@juliusmarminge juliusmarminge merged commit cbf3fcd into t3-oss:finn/eslint-prettier May 18, 2023
1 check passed
@ryanagillie
Copy link

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants