Bump Swift Argument Parser checkout to 1.1.4 #59009

daltonclaybrook · 2022-05-21T18:00:37Z

This changes the checked-out version of swift-argument-parser from 1.0.3 to 1.1.2 in update-checkout-config.json as requested in apple/swift-driver#1106 . Please let me know if any other changes are required as I'm not very familiar with how this file is used. I took my cues from #41126

utils/update_checkout/update-checkout-config.json

compnerd · 2022-05-21T18:10:26Z

@swift-ci please build toolchain macOS platform

compnerd · 2022-05-21T18:10:33Z

@swift-ci please build toolchain Linux platform

compnerd · 2022-05-21T18:14:31Z

Please test with following PRs:
swiftlang/swift-installer-scripts#91

@swift-ci please build toolchain Windows platform

compnerd · 2022-05-22T18:42:31Z

Please test with following PRs:
swiftlang/swift-installer-scripts#91

@swift-ci please build toolchain Windows platform

compnerd · 2022-05-22T18:42:37Z

Please test with following PRs:
swiftlang/swift-installer-scripts#91

@swift-ci please build toolchain Linux platform

compnerd · 2022-05-22T18:42:48Z

Please test with following PRs:
swiftlang/swift-installer-scripts#91

@swift-ci please build toolchain macOS platform

compnerd · 2022-06-05T19:26:05Z

@swift-ci please clean test

CodaFi · 2022-08-18T03:50:21Z

swiftlang/swift-installer-scripts#91

@swift-ci please build toolchain macOS platform

CodaFi · 2022-08-18T03:50:46Z

swiftlang/swift-installer-scripts#91

@swift-ci please build toolchain Windows platform

MaxDesiatov · 2022-10-24T16:23:21Z

swiftlang/swift-installer-scripts#91

@swift-ci please build toolchain Windows platform

utils/update_checkout/update-checkout-config.json

MaxDesiatov · 2022-11-05T19:24:48Z

@swift-ci please smoke test

MaxDesiatov · 2022-11-06T10:10:16Z

@swift-ci please smoke test

MaxDesiatov · 2022-11-07T09:52:46Z

@swift-ci please smoke test

MaxDesiatov · 2022-12-15T13:57:34Z

@swift-ci please test Windows

MaxDesiatov · 2022-12-15T13:58:50Z

swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
@swift-ci please clean test Windows

MaxDesiatov · 2022-12-15T17:48:52Z

swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
@swift-ci please build toolchain Windows platform

MaxDesiatov · 2022-12-15T21:02:19Z

swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
@swift-ci please build toolchain Windows platform

MaxDesiatov · 2022-12-15T23:12:54Z

swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
@swift-ci please build toolchain Windows platform

MaxDesiatov · 2022-12-21T14:01:45Z

swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
@swift-ci please build toolchain Windows platform

MaxDesiatov · 2023-01-03T17:28:32Z

swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
@swift-ci please clean test

MaxDesiatov · 2023-01-03T17:28:45Z

swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
@swift-ci please build toolchain

MaxDesiatov · 2023-01-04T14:11:14Z

@compnerd could you confirm that the Windows failure is not related to this PR? Thanks!

compnerd · 2023-01-04T14:29:31Z

@MaxDesiatov can't do that - we need to get a complete toolchain build for Windows because there can be a lurking issue - swift-installer-scripts may need to be updated.

compnerd · 2023-01-04T14:30:06Z

Please test with following PRs:
swiftlang/sourcekit-lsp#689

@swift-ci please build toolchain Windows platfrom

MaxDesiatov · 2023-01-04T14:31:00Z

swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
swiftlang/sourcekit-lsp#689
@swift-ci please build toolchain Windows platform

compnerd

I think that this may need swiftlang/swift-installer-scripts#91 to be merged in tandem to ensure that we don't break the Windows build.

compnerd · 2023-01-04T14:31:53Z

@MaxDesiatov - when this goes in, we need to make a change to compnerd/swift-build as well to ensure that the official Windows builds are updated as well.

MaxDesiatov · 2023-01-04T16:00:40Z

swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
swiftlang/sourcekit-lsp#689
@swift-ci please build toolchain Windows platform

MaxDesiatov · 2023-01-04T17:15:09Z

swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
swiftlang/sourcekit-lsp#689
@swift-ci please build toolchain Windows platform

MaxDesiatov · 2023-01-04T19:04:41Z

@compnerd it failed with

Archiving artifacts
‘build/artifacts/*’ doesn’t match anything, but ‘*’ does. Perhaps that’s what you mean?
ERROR: Step ‘Archive the artifacts’ failed: No artifacts found that match the file pattern "build/artifacts/*". Configuration error?

what would be the best way to diagnose this?

MaxDesiatov · 2023-01-04T19:43:53Z

swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
swiftlang/sourcekit-lsp#689
@swift-ci please build toolchain Windows platform

MaxDesiatov · 2023-01-05T07:51:43Z

swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
@swift-ci please build toolchain Windows platform

MaxDesiatov · 2023-01-05T11:05:27Z

swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
swiftlang/sourcekit-lsp#673
@swift-ci please build toolchain Windows platform

MaxDesiatov · 2023-01-05T11:05:55Z

swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
swiftlang/sourcekit-lsp#673
@swift-ci clean test

MaxDesiatov · 2023-01-05T13:56:27Z

swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
swiftlang/sourcekit-lsp#673
@swift-ci clean test

MaxDesiatov · 2023-01-05T13:56:52Z

swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
swiftlang/sourcekit-lsp#673
@swift-ci build toolchain

compnerd · 2023-01-05T15:41:36Z

@MaxDesiatov the build logs are the most helpful thing here:

swift-ci@EC2AMAZ-JCVOGM7 C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows>msbuild C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\toolchain.wixproj   -p:RunWixToolsOutOfProc=true   -p:OutputPath=T:\package\toolchain\   -p:IntermediateOutputPath=T:\package\toolchain\   -p:DEVTOOLS_ROOT=T:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain   -p:TOOLCHAIN_ROOT=T:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain 
Microsoft (R) Build Engine version 16.10.2+857e5a733 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 1/5/2023 3:14:53 PM.
Project "C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\toolchain.wixproj" on node 1 (default targets).
PrepareForBuild:
  Creating directory "T:\package\toolchain\".
HarvestDirectory:
  C:\Program Files (x86)\WiX Toolset v3.11\bin\Heat.exe dir T:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\lib\clang -cg ClangResources -dr _usr_lib_clang -scom -sreg -srd -var var.TOOLCHAIN_ROOT_USR_LIB_CLANG -nologo -gg -nologo -sfrag -out T:\package\toolchain\_ClangResources_dir.wxs
Compile:
  C:\Program Files (x86)\WiX Toolset v3.11\bin\candle.exe -dProductVersion=0.0.0 -dDEVTOOLS_ROOT=T:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain -dTOOLCHAIN_ROOT=T:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain -dTOOLCHAIN_ROOT_USR_LIB_CLANG=T:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\lib\clang -dConfiguration=Debug -dOutDir=T:\package\toolchain\ -dPlatform=AnyCPU -dProjectDir=C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\ -dProjectExt=.wixproj -dProjectFileName=toolchain.wixproj -dProjectName=toolchain -dProjectPath=C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\toolchain.wixproj -dTargetDir=T:\package\toolchain\ -dTargetExt=.msi -dTargetFileName=toolchain.msi -dTargetName=toolchain -dTargetPath=T:\package\toolchain\toolchain.msi -out T:\package\toolchain\ -ext "C:\Program Files (x86)\WiX Toolset v3.11\bin\\WixUIExtension.dll" toolchain-amd64.wxs T:\package\toolchain\_ClangResources_dir.wxs
Link:
  C:\Program Files (x86)\WiX Toolset v3.11\bin\Light.exe -out T:\package\toolchain\toolchain.msi -pdbout T:\package\toolchain\toolchain.wixpdb -cultures:null -ext "C:\Program Files (x86)\WiX Toolset v3.11\bin\\WixUIExtension.dll" -contentsfile T:\package\toolchain\toolchain.wixproj.BindContentsFileListnull.txt -outputsfile T:\package\toolchain\toolchain.wixproj.BindOutputsFileListnull.txt -builtoutputsfile T:\package\toolchain\toolchain.wixproj.BindBuiltOutputsFileListnull.txt -wixprojectfile C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\toolchain.wixproj T:\package\toolchain\toolchain-amd64.wixobj T:\package\toolchain\_ClangResources_dir.wixobj
C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\toolchain-amd64.wxs(685): error LGHT0103: The system cannot find the file 'T:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\ArgumentParserToolInfo.dll'. [C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\toolchain.wixproj]
Done Building Project "C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\toolchain.wixproj" (default targets) -- FAILED.

Build FAILED.

"C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\toolchain.wixproj" (default target) (1) ->
(Link target) -> 
  C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\toolchain-amd64.wxs(685): error LGHT0103: The system cannot find the file 'T:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\ArgumentParserToolInfo.dll'. [C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\toolchain.wixproj]

    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:05.20

swiftlang/swift-installer-scripts#91 is what is needed.

compnerd · 2023-01-05T15:42:09Z

Please test with following PRs:
swiftlang/swift-installer-scripts#91
swiftlang/swift-package-manager#5884
swiftlang/swift-driver#1218
swiftlang/sourcekit-lsp#673

@swift-ci please build toolchain windows platform

MaxDesiatov · 2023-01-05T15:42:37Z

@compnerd could it also be Foundation test failures that have some impact?

The following tests FAILED:
	606 - TestFoundation.TestFileManager-test_homedirectoryForUser (ILLEGAL)
	611 - TestFoundation.TestFileManager-test_emptyFilename (Exit code 0xc0000409
)
	1281 - TestFoundation.TestNSString-test_NSHomeDirectoryForUser (Failed)
	1283 - TestFoundation.TestNSString-test_expandingTildeInPath (Failed)
Errors while running CTest

compnerd · 2023-01-05T15:44:22Z

The Foundation tests are something that I am hoping to look into soon, but the error is what I referenced in #59009 (comment). It results in a missing MSI as the manifest is stating that a file needs to be shipped but is not available due to changes in swift-argument-parser. The result is that we cannot build the MSI nor installer as the manifest is no longer correct.

Bump Swift Argument Parser checkout to 1.1.2

2fd4e39

daltonclaybrook mentioned this pull request May 21, 2022

Upgrade Swift Argument Parser to version 1.1.2 swiftlang/swift-driver#1106

Closed

compnerd reviewed May 21, 2022

View reviewed changes

utils/update_checkout/update-checkout-config.json Outdated Show resolved Hide resolved

Revert release/5.7 back to using swift-argument-parser 1.0.3

fce4f32

This comment was marked as outdated.

Sign in to view

MaxDesiatov reviewed Nov 4, 2022

View reviewed changes

utils/update_checkout/update-checkout-config.json Outdated Show resolved Hide resolved

Bump to 1.1.4

2984038

MaxDesiatov reviewed Nov 4, 2022

View reviewed changes

utils/update_checkout/update-checkout-config.json Outdated Show resolved Hide resolved

Bump version

136279b

This comment was marked as outdated.

Sign in to view

MaxDesiatov changed the title ~~Bump Swift Argument Parser checkout to 1.1.2~~ Bump Swift Argument Parser checkout to 1.1.4 Nov 4, 2022

This comment was marked as outdated.

Sign in to view

This was referenced Nov 7, 2022

Package.swift: bump ArgumentParser to 1.1.4 swiftlang/swift-driver#1218

Merged

Commands: update ArgumentParser to 1.1.4 swiftlang/swift-package-manager#5884

Merged

This comment was marked as duplicate.

Sign in to view

MaxDesiatov requested a review from compnerd January 4, 2023 14:11

compnerd approved these changes Jan 4, 2023

View reviewed changes

shahmishal approved these changes Jan 10, 2023

View reviewed changes

shahmishal merged commit 64e65c9 into swiftlang:main Jan 10, 2023

Bump Swift Argument Parser checkout to 1.1.4 #59009

Bump Swift Argument Parser checkout to 1.1.4 #59009

Conversation

daltonclaybrook commented May 21, 2022

compnerd commented May 21, 2022

compnerd commented May 21, 2022

compnerd commented May 21, 2022

compnerd commented May 22, 2022

compnerd commented May 22, 2022

compnerd commented May 22, 2022

compnerd commented Jun 5, 2022

CodaFi commented Aug 18, 2022

CodaFi commented Aug 18, 2022

MaxDesiatov commented Oct 24, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

MaxDesiatov commented Nov 5, 2022

MaxDesiatov commented Nov 6, 2022

MaxDesiatov commented Nov 7, 2022

This comment was marked as duplicate.

MaxDesiatov commented Dec 15, 2022

MaxDesiatov commented Dec 15, 2022

MaxDesiatov commented Dec 15, 2022

MaxDesiatov commented Dec 15, 2022

MaxDesiatov commented Dec 15, 2022

MaxDesiatov commented Dec 21, 2022

MaxDesiatov commented Jan 3, 2023

MaxDesiatov commented Jan 3, 2023

MaxDesiatov commented Jan 4, 2023

compnerd commented Jan 4, 2023

compnerd commented Jan 4, 2023

MaxDesiatov commented Jan 4, 2023

compnerd left a comment

Choose a reason for hiding this comment

compnerd commented Jan 4, 2023

MaxDesiatov commented Jan 4, 2023

MaxDesiatov commented Jan 4, 2023

MaxDesiatov commented Jan 4, 2023

MaxDesiatov commented Jan 4, 2023

MaxDesiatov commented Jan 5, 2023

MaxDesiatov commented Jan 5, 2023

MaxDesiatov commented Jan 5, 2023

MaxDesiatov commented Jan 5, 2023

MaxDesiatov commented Jan 5, 2023

compnerd commented Jan 5, 2023

compnerd commented Jan 5, 2023

MaxDesiatov commented Jan 5, 2023

compnerd commented Jan 5, 2023