Package.swift: bump ArgumentParser to 1.1.4 #1218
Conversation
|
@swift-ci please test with the following PRs |
|
@MaxDesiatov this repository does not support cross-repo CI. |
|
Fair enough, thanks for the guidance 👍 |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
@swift-ci please test |
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
|
@swift-ci please test Windows |
| @@ -333,9 +333,8 @@ def install_libraries(args, build_dir, universal_lib_dir, toolchain_lib_dir, tar | |||
|
|
|||
| # Install the swift-argument-parser shared libraries into the toolchain lib | |||
| package_subpath = os.path.join(args.configuration, 'dependencies', 'swift-argument-parser') | |||
| for lib in ['libArgumentParser', 'libArgumentParserToolInfo']: | |||
There was a problem hiding this comment.
@DougGregor this is a change I have doubts about, but it apparently makes the error in this CI run go away: https://ci.swift.org/job/swift-PR-macos/5203/console
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
|
Just wondering, any reason to not pull in 1.2.0? |
|
There's a regression in 1.2.0 due to which SwiftPM bootstrap build fails. |
|
@swift-ci test Windows |
|
Bleh, the windows failure looks like a regression in LSP (wonder if the windows build got triggered on changes 🤔) |
|
It has been bumped in all other places, I have corresponding PRs waiting to be merged. Do you expect any additional changes to this PR specifically? |
|
Please test with following PRs: @swift-ci please test Windows platform |
|
I've been told upthread that this repository doesn't support cross-repo testing, but I hope that Windows CI run passes anyway |
|
@swift-ci test Windows |
|
@compnerd Windows build is passing now, would you mind re-reviewing? Thanks! |
There was a problem hiding this comment.
The change itself looks fine, but please make sure that you do a cross-repo test in apple/swift with @swift-ci please build toolchain Windows platform and then test the resulting installer. The problem is that there can be something subtle in the packaging where a dependency is either missing and expected or is missing and unexpected and the tools will not function.
|
@compnerd thank you. I've pinged you in the corresponding PR, for some reason the Windows toolchain CI run can't find artifacts, even though there are no obvious failures. I've shared the error message here swiftlang/swift#59009 (comment) |
|
@MaxDesiatov - that is what happens when the necessary changes are missing! You need a parallel change to apple/swift-installer-scripts: swiftlang/swift#59009 (review) |
|
That did indeed help, thanks for the review and finding the root cause of the build failure! |
No description provided.