Diagnose unavailable closures without types #40660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
Linux test failure in |
|
@swift-ci please test Linux |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test |
tshortli
approved these changes
Oct 7, 2022
In complex situations, a type would not be assigned to an abstract closure that was the declaration context of the declaration being checked. This used to cause crashes because you couldn't query a closure on whether it was an async context if it didn't have a type assigned. This behaviour has been updated to lazily compute the function decl ext info if the type hasn't already been assigned. This means that calling `AbstractClosureExpr::isAsyncContext` is now safe, even when a type has not yet been assigned. The request change was added in commit c3b6160.
etcwilde
force-pushed
the
ewilde/abstract-closures-are-alright-now
branch
from
e80a837
to
44ac39a
Compare
|
@swift-ci please test |
xedin
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In complex situations, a type would not be assigned to an abstract
closure that was the declaration context of the declaration being
checked. This used to cause crashes because you couldn't query a closure
on whether it was an async context if it didn't have a type assigned.
This behaviour has been updated to lazily compute the function decl ext
info if the type hasn't already been assigned. This means that calling
AbstractClosureExpr::isAsyncContextis now safe, even when a type hasnot yet been assigned. This was cleaned up by #40544.