Extend "uses concurrency features" checks for closures currently being type checked #40544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e body. Use this to enable better detection of async contexts when determining whether to diagnose problems with concurrency. Part of SR-15131 / rdar:https://problem/82535088.
|
@swift-ci please smoke test |
… features When evaluating whether code is within a closure that uses concurrency features, use the type of the closure as it's known during type checking, so that contextual information (e.g., it's passed to a `@Sendable` or `async` parameter of function type) can affect the result. This corrects the definition for doing strict checking within a minimal context for the end result of the type-check, rather than it's initial state, catching more issues. Fixes SR-15131 / rdar:https://problem/82535088.
|
@swift-ci please smoke test |
DougGregor
changed the title
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When type-checking a closure, use the type that it will have in context (e.g., considering inferred
@Sendableandasync) to determine whether that closure should perform strict checking. This allows us to better detect when we should diagnose data races in Swift 5.x code.Fixes SR-15131 / rdar:https://problem/82535088.