Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated grays #743

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix duplicated grays #743

wants to merge 1 commit into from

Conversation

rauhul
Copy link
Contributor

@rauhul rauhul commented Jun 25, 2024

Removes figure-gray-secondary-alt in favor of figure-gray-tertiary which already had the exact same color values.

Fixes fill-quaternary to have different colors in dark and light mode.

Removes figure-gray-secondary-alt in favor of figure-gray-tertiary which
already had the exact same color values.

Fixes fill-quaternary to have different colors in dark and light mode.
@rauhul
Copy link
Contributor Author

rauhul commented Jun 25, 2024

@swift-ci test

@rauhul
Copy link
Contributor Author

rauhul commented Jun 25, 2024

Note: there is no observable affect of this change on the website visually

Copy link
Contributor

@federicobucchi federicobucchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@rauhul
Copy link
Contributor Author

rauhul commented Jun 28, 2024

What's the policy on merging this PR, since moving to the swiftlang org I do not seem to be able to merge it myself.

@federicobucchi
Copy link
Contributor

I am waiting for another approval from someone from the working group: https://www.swift.org/website-workgroup/

@rauhul
Copy link
Contributor Author

rauhul commented Jun 28, 2024

Gotcha, is that the general policy? if so would it make sense to require PRs to have 2 approvals?

@federicobucchi
Copy link
Contributor

It is hard to enforce pragmatically specific rules because there are specific people depending on the page and the type of change. Sometimes we need approval from someone in PR (which is included also in the WG). Sometimes 1 approval is enough because the change was discussed / approved in forums.swift.org. So difficult to set a specific unique rule.

@alexandersandberg
Copy link
Member

alexandersandberg commented Jun 29, 2024

Personally, I think it's better to wait with these smaller improvements/refactors (unless they provide value enough that we don't want to wait with it) until we get a chance to revisit the whole color palette—something we (the website workgroup) want to look into soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants