Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize visual appearance of grids #742

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rauhul
Copy link
Member

@rauhul rauhul commented Jun 25, 2024

Updates all grids except for package grids to take a more layered
appearance matching that of the tabs.

Adds support for "prefers-contrast: more" to use the previous higher
contrast style.

Removes the many grid css styles and replaces them with a common grid
style in the elements folder than can be reused between pages.

Builds on top of #743, #749, and #751

@rauhul
Copy link
Member Author

rauhul commented Jun 25, 2024

@swift-ci test

@rauhul
Copy link
Member Author

rauhul commented Jun 25, 2024

older screenshots

Before & After

Home

Screenshot 2024-06-25 at 1 56 19 PM Screenshot 2024-06-25 at 1 57 56 PM

Getting Started

Screenshot 2024-06-25 at 1 56 30 PM Screenshot 2024-06-25 at 1 58 03 PM

Packages

Screenshot 2024-06-25 at 1 58 26 PM Screenshot 2024-06-25 at 1 58 13 PM

Tools

Screenshot 2024-06-25 at 1 58 39 PM Screenshot 2024-06-25 at 1 58 46 PM

@shahmishal shahmishal added the workgroup-to-discuss Issue/PR to be discussed by the SWWG in the next meeting label Jun 25, 2024
@heckj
Copy link
Member

heckj commented Jun 25, 2024

For my part, it lowers the reading contrast in those grey-blocked sections a bit too much. No qualms about the added visual structure blocking things out, but I'd at least toss in a request for a darker font/weighting to get the contrast back up.

@rauhul
Copy link
Member Author

rauhul commented Jun 25, 2024

For my part, it lowers the reading contrast in those grey-blocked sections a bit too much. No qualms about the added visual structure blocking things out, but I'd at least toss in a request for a darker font/weighting to get the contrast back up.

For both dark and light mode or just one specifically?

@heckj
Copy link
Member

heckj commented Jun 25, 2024

Ah, sorry - really just the light mode. The difference in the dark mode didn't my eyes as hard - it's a little reduced, but not to a level that makes reading more difficult for me. I'll never complain about a bit more contrast though ;-)

@dempseyatgithub
Copy link
Contributor

Since the existing style is very high contrast, we should consider preserving it as a prefers-contrast CSS media query for accessibility users requiring high contrast. I don't think that has been a concern before with the existing style.

@dempseyatgithub
Copy link
Contributor

I find the use of the orange color for call outs, for example the "Get Involved" section of the package page to draw far too much attention to that element. Getting involved is important, which is why it is in a call out box, but it is not the most important thing on the page.

I find the orange color draws the eye too much for these kind of call outs.

Changing the link text and underline from blue to orange also make the link / call to action in the call out much less visible. Scanning the original, it is clear the box wants people to get involved with the main way of getting involved as 'Nominate packages'.

Using the orange color for the call to action about the migration guide on the home page is meant to draw the eye, especially on a home page where the content is largely static, and where directing visitors to the migration guide is an important and transient announcement.

@rauhul
Copy link
Member Author

rauhul commented Jun 28, 2024

@dempseyatgithub I pulled the banner changes out into #749, could you take a look there?

@rauhul
Copy link
Member Author

rauhul commented Jun 28, 2024

Before & After

Home
Light - Default Screenshot 2024-06-28 at 3 33 05 PM
Light - Increased Contrast Screenshot 2024-06-28 at 3 33 12 PM
Dark - Default Screenshot 2024-06-28 at 3 33 31 PM
Dark - Increased Contrast Screenshot 2024-06-28 at 3 33 38 PM
Packages
Light - Default Screenshot 2024-06-28 at 3 40 58 PM
Light - Increased Contrast Screenshot 2024-06-28 at 3 41 01 PM
Dark - Default Screenshot 2024-06-28 at 3 41 13 PM
Dark - Increased Contrast Screenshot 2024-06-28 at 3 41 17 PM
Install
Light - Default Screenshot 2024-06-28 at 3 34 16 PM
Light - Increased Contrast Screenshot 2024-06-28 at 3 34 19 PM
Dark - Default Screenshot 2024-06-28 at 3 34 02 PM
Dark - Increased Contrast Screenshot 2024-06-28 at 3 34 06 PM

@rauhul rauhul changed the title Modernize look and feel of grids Modernize visual appearance of grids Jun 28, 2024
@kubamracek
Copy link
Contributor

Large +1 from me, this is a big improvement.

@shahmishal shahmishal removed the workgroup-to-discuss Issue/PR to be discussed by the SWWG in the next meeting label Jul 30, 2024
Copy link
Member

@kaishin kaishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rauhul Can we merge the other PRs and rebase before final review?

That aside, we need to increase the contrast in light mode even further by toning down the background gray, otherwise it would be a regression in accessibility for many.

@kaishin kaishin removed their assignment Aug 10, 2024
@kaishin
Copy link
Member

kaishin commented Aug 29, 2024

@rauhul Happy to review this once rebased. Thanks!

@kaishin kaishin self-assigned this Aug 29, 2024
Updates all grids except for package grids to take a more layered
appearance matching that of the tabs.

Adds support for "prefers-contrast: more" to use the previous higher
contrast style.

Removes the many grid css styles and replaces them with a common grid
style in the elements folder than can be reused between pages.
@rauhul
Copy link
Member Author

rauhul commented Sep 7, 2024

anything blocking this?

@rauhul
Copy link
Member Author

rauhul commented Sep 7, 2024

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants