Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change expressions with 'file' type to 'binary' type #185

Merged
merged 4 commits into from
Dec 26, 2019

Conversation

lion7
Copy link
Contributor

@lion7 lion7 commented Sep 26, 2018

In the Swagger 2.0 specification you could specify a file upload using the 'special' parameter type file.
This type does not exist in the OpenAPI 3.0 specification, instead the binary format should be used.

Currently (almost) all mustache/handlebars templates check a file using the expression {{#is this 'file'}}
An solution is to change this to {{#is this 'binary'}}. This does imply that all relevant templates have to be changed. I will create another pull request where this is not necessary but that requires a change to the intepretation of type's.

@HugoMario could you review both PR's and pick the most preferred solution?

@HugoMario
Copy link
Contributor

thanks for your PR's i'll take a time this friday or earlyy next week to review them a merge them

@HugoMario
Copy link
Contributor

@lion7 this makes sense, however some generators still works with file type, besides is not present on OAS3, i´ll work with your PR in order to use an option that allow us to work with both data type accordinng users selection. thanks!

@HugoMario HugoMario merged commit 467a411 into swagger-api:master Dec 26, 2019
@mfvitale
Copy link

Hi,
in which release is this fix present?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants