Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the schema types 'file' and 'binary' identical #184

Merged
merged 1 commit into from
Jun 8, 2019

Conversation

lion7
Copy link
Contributor

@lion7 lion7 commented Sep 26, 2018

In the Swagger 2.0 specification you could specify a file upload using the 'special' parameter type file.
This type does not exist in the OpenAPI 3.0 specification, instead the binary format should be used.

Currently (almost) all mustache/handlebars templates check a file using the expression {{#is this 'file'}}
An solution to avoid changing all templates is to ensure that these 2 types are configured identically as has been done in this pull request. I will create another pull request where all relevant templates are changed to check for the binary type instead.

@HugoMario could you review both PR's and pick the most preferred solution?

@HugoMario HugoMario added this to the v3.0.2 milestone Oct 3, 2018
@HugoMario HugoMario merged commit 1af40b2 into swagger-api:master Jun 8, 2019
@HugoMario
Copy link
Contributor

thanks a lot @lion7 sorry for so loooong delay. Honestly i thought this one had been alreayd merged

@lion7
Copy link
Contributor Author

lion7 commented Jun 8, 2019

@HugoMario np, I'm happy that it at least got merged 😄

@lion7
Copy link
Contributor Author

lion7 commented Jun 8, 2019

@HugoMario you might also want check out #185 and #373 which contains a more correct fix

@HugoMario
Copy link
Contributor

yes, i'll take a time for them this comming week. word !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants