Re-bundle server app in adapter-node #1648
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1257. This makes adapter-node run the server-side app through esbuild as part of the build process, treating anything in (prod)
dependencies
as external, and bundling everything else. This means that, for example,@sveltejs/kit
will no longer need to be installed when deploying the production app - and any other dependencies that the app adds asdevDependencies
will also be bundled in. This means that, in production, you should be able to copy over yourpackage.json
andbuild/
, runnpm install --production
, and runnode build
- which is what you'd expect to be able to do.These changes seem to behave as expected on the project I have at work (which adds a number of dependencies, some of which should be bundled on the server and some of which should not) - but I'd still appreciate some more eyes on this PR.
Before submitting the PR, please make sure you do the following
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts