Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kit and svelte are listed a devDependency in demos but needed for running build #1428

Closed
bleucitron opened this issue May 12, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@bleucitron
Copy link
Contributor

Once you built a project with adapter-node, node build does not work without @sveltejs/kit and svelte in node_modules.

Cannot find package '@sveltejs/kit' imported from /Users/Romain/Code/tutos/sveltekit-app/build/app.js

On the kit template projects (demo or skeleton), @sveltejs/kit and svelte are listed as devDependencies.
My understanding was that you should be able to run a project in production without any devDependencies installed.

Plus i thought that all prod dependencies were packaged by rollup (via vite) on build, which does not seem to be the case since we still have import such as

// in build/app.js for DEMO APP
import cookie from "cookie";

I'm not sure why we should not keep @sveltejs/kit and svelte as devDependencies, but at the same time we currently need to have the corresponding folders in node_modules...

Am i missing something here ?

@Conduitry
Copy link
Member

Closing this as a duplicate of #1257. This should also be fixed by #1648.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants