Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved doc & logging #40

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Improved doc & logging #40

merged 2 commits into from
Dec 7, 2022

Conversation

zzachw
Copy link
Collaborator

@zzachw zzachw commented Dec 7, 2022

  1. Improved doc for metrics
  2. Better logging to console

@zzachw
add docstring for metrics (#38)
7c51d21
@zzachw
Fix logging problem (#39)
6aad348 
* fix duplicated logging problem

* fix rnn dropout warning

* reformat dataset statistics print
ycq091044
ycq091044 approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@ycq091044 ycq091044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, already reviewed from "feature" -> "develop".

pat-jj
pat-jj approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@pat-jj pat-jj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zzachw zzachw merged commit 3a0f875 into master Dec 7, 2022
@zzachw
Copy link
Collaborator Author

zzachw commented Dec 8, 2022

This PR is force reverted as "rebase and merge" makes the develop and master branches diverged from each other.

@zzachw zzachw mentioned this pull request Dec 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycq091044 ycq091044 ycq091044 approved these changes

@pat-jj pat-jj pat-jj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zzachw @ycq091044 @pat-jj